Login
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 00:40:11 +0000 (00:40 +0000)]
Adding an EPIC config file
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 00:12:56 +0000 (00:12 +0000)]
Dealing with more Eclipse files
Jeffrey Ryan Thalhammer [Sat, 23 Aug 2008 23:17:59 +0000 (23:17 +0000)]
Added a build.xml script to all distributions. Tools like Eclipse and Intelli-J
have good interfaces for creating and running Ant scripts. These files
just serve as wrappers around Build.PL, so you can take advantage of those
interfaces when working with Perl dists.
Jeffrey Ryan Thalhammer [Sat, 23 Aug 2008 23:07:45 +0000 (23:07 +0000)]
Taking premptive steps: adding my forthcoming build.xml to MANIFEST.SKIP
Elliot Shank [Sat, 23 Aug 2008 01:19:41 +0000 (01:19 +0000)]
Fix PBP page numbers in ProhibitMixedCaseVars and
ProhibitMixedCaseVars.
Elliot Shank [Fri, 22 Aug 2008 21:15:56 +0000 (21:15 +0000)]
Forgot to set svn:keywords on
RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 02:34:34 +0000 (02:34 +0000)]
Make tests comply with
RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 02:24:50 +0000 (02:24 +0000)]
Make rest of code comply with
RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 02:07:35 +0000 (02:07 +0000)]
Make Policies comply with
RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 01:43:08 +0000 (01:43 +0000)]
Implement RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 01:18:27 +0000 (01:18 +0000)]
Create an option for CodeLayout::ProhibitQuotedWordLists
that makes it complain about word lists containing non-word
characters again.
Elliot Shank [Fri, 22 Aug 2008 00:51:21 +0000 (00:51 +0000)]
Add ".project" to all of the MANIFEST.SKIP files.
Jeffrey Ryan Thalhammer [Thu, 21 Aug 2008 01:12:07 +0000 (01:12 +0000)]
Color for high-severity violations is now magenta,
because this looks better on typical terminals with
a white background. RT #38511.
Jeffrey Ryan Thalhammer [Thu, 21 Aug 2008 00:42:15 +0000 (00:42 +0000)]
Adding username for anonymous checkout from our repository.
Thanks to Schwern for suggesting. #RT 38628.
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 06:05:09 +0000 (06:05 +0000)]
I started using Eclipse for all my Perl work. So I am checking in the Eclipse project files for each distro. I am not really sure if these should be in the repository or not
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 05:39:41 +0000 (05:39 +0000)]
Undoing r2675. Now that the "-color" is no longer being set in _parse_command_line(), we no longer need to worry about double dashes in the keys of the argument hash for P::C->new(). Default values for the command-line options should only be defined in the OptionsProcessor.
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 05:31:59 +0000 (05:31 +0000)]
Added failing test case that came to me in the mail today.
Elliot Shank [Sun, 17 Aug 2008 10:56:48 +0000 (10:56 +0000)]
Change perlcritic to not unconditionally add a "-" to the
front of options to be passed to Perl::Critic::new() in
response to RT #38458.
Elliot Shank [Sun, 17 Aug 2008 10:30:08 +0000 (10:30 +0000)]
Make the changes to
RegularExpressions::RequireExtendedFormatting more clear in
Changes.
Elliot Shank [Sun, 17 Aug 2008 10:18:21 +0000 (10:18 +0000)]
Clean up Schwern's
RegularExpressions::RequireExtendedFormatting patch. Renamed
the min_regex_length option to
minimum_regex_length_to_complain_about. The way the
allow_with_whitespace was coded, if the regex contained any
whitespace at all, it was exempt. Instead, I made regexes
that only contain word characters and whitespace exempt by
default, and added a strict option. I'm not so sure about
this one.
Elliot Shank [Sun, 17 Aug 2008 09:19:38 +0000 (09:19 +0000)]
Apply raw patch from Schwern that adds options to
RegularExpressions::RequireExtendedFormatting.
Elliot Shank [Sat, 16 Aug 2008 02:09:57 +0000 (02:09 +0000)]
Fix missing word in the ProhibitNoWarnings POD.
Elliot Shank [Sat, 16 Aug 2008 02:03:03 +0000 (02:03 +0000)]
Update Changes with the new allow_with_category_restriction
option for TestingAndDebugging::ProhibitNoWarnings.
Elliot Shank [Sat, 16 Aug 2008 01:58:43 +0000 (01:58 +0000)]
Clean up both existing problems and problems with Schwern's
patch in TestingAndDebugging::ProhibitNoWarnings.
Elliot Shank [Sat, 16 Aug 2008 01:29:27 +0000 (01:29 +0000)]
Apply raw patch from Schwern for
TestingAndDebugging::ProhibitNoWarnings. Needs some rework.
The special value in the allow option? Eww. Not too hard
to fix, though.
Elliot Shank [Thu, 14 Aug 2008 05:01:46 +0000 (05:01 +0000)]
Clean up self compliance problems introduced by Schwern's
pager patch. Still need to actually review the patch. :]
Elliot Shank [Thu, 14 Aug 2008 03:58:27 +0000 (03:58 +0000)]
Apply the unmodified patch from Schwern (modulo dealing with
RJBS' change to support PAR). I have no idea whether tests
or anything works at this point. I just considered it
worthwhile to capture the change as it is before modifying
it further.
Elliot Shank [Thu, 14 Aug 2008 03:49:53 +0000 (03:49 +0000)]
Comment in P::C::Document about underscores in perl version
dependencies, i.e. "use 5.008_005;".
Elliot Shank [Wed, 13 Aug 2008 17:07:25 +0000 (17:07 +0000)]
Add the xt directory to no_index in Build.PL.
Elliot Shank [Mon, 11 Aug 2008 20:12:20 +0000 (20:12 +0000)]
Update Changes to reflect the fix for RT #38380 that RJBS
did.
Ricardo Signes [Mon, 11 Aug 2008 19:54:16 +0000 (19:54 +0000)]
bugfix for running under PAR, RT #38380
Elliot Shank [Sat, 9 Aug 2008 20:49:52 +0000 (20:49 +0000)]
in 20_policies.t, specify a more useful format for
violations that are shown when there's a test failure.
Inspired by failures in
Variables/RequireLocalizedPunctuationVars.run occurring when
running on a 5.10.0 + patches perl.
Elliot Shank [Wed, 30 Jul 2008 01:49:36 +0000 (01:49 +0000)]
Another example of a problem in
ProhibitEscapedMetacharacters with character classes.
Elliot Shank [Wed, 30 Jul 2008 01:41:56 +0000 (01:41 +0000)]
Failing test for
RegularExpressions::ProhibitEscapedMetacharacters.
Chris Dolan [Mon, 28 Jul 2008 02:40:25 +0000 (02:40 +0000)]
Forgot to update Changes
Chris Dolan [Mon, 28 Jul 2008 02:39:04 +0000 (02:39 +0000)]
Ternaries now satisfy RequireCheckingReturnValueOfEval:
eval { require Foo; 1; } ? ok() : nok();
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 23:30:53 +0000 (23:30 +0000)]
Describe policy for enforcing correct spelling of variable names.
This all got started here: http://rt.cpan.org/Ticket/Display.html?id=37899
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 23:20:48 +0000 (23:20 +0000)]
Fixed spelling error. RT #37899
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 06:14:55 +0000 (06:14 +0000)]
CodeLayout::ProhibitQuotedWordLists also now applies to the
import arguments of a C<use> statement. RT #24467.
I also cleaned up some of the tests for this Policy.
Disabled RequireConstantOnLeftSideOfEquality until I decide
which distro to put that policy in.
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 03:35:46 +0000 (03:35 +0000)]
ProhibitQuotedWordLists does not apply to lists
that contain non-words. RT #37886.
Elliot Shank [Thu, 24 Jul 2008 14:50:59 +0000 (14:50 +0000)]
Add RT # to ProhibitPostfixControls TODO.
Elliot Shank [Thu, 24 Jul 2008 14:49:56 +0000 (14:49 +0000)]
TODO about ControlStructures::ProhibitPostfixControls
changing its explanation when "do {} while" is found.
Jeffrey Ryan Thalhammer [Wed, 23 Jul 2008 04:18:09 +0000 (04:18 +0000)]
Diddling svn:ignore.
Jeffrey Ryan Thalhammer [Wed, 23 Jul 2008 04:14:28 +0000 (04:14 +0000)]
Added my first new policy in a very long time. So I might be a bit
rusty here...
This is a partial implementation of the RequireConstantBeforeOperator
policy mentioned in the TODO list. For now, it only applies to the
'==' and 'eq' operators. But if you guys think it should be extended
to all other comparison operators, then I can do that.
Elliot Shank [Tue, 22 Jul 2008 14:20:39 +0000 (14:20 +0000)]
20_policies.t didn't have a "1;" at the end, so it failed to
load in 20_policies.t_without_optional_dependencies.t.
Elliot Shank [Tue, 22 Jul 2008 13:47:03 +0000 (13:47 +0000)]
Bump P::C version to 1.090.
Elliot Shank [Tue, 22 Jul 2008 13:44:20 +0000 (13:44 +0000)]
ProhibitSingleCharAlternation test was failing when
Regexp::Parser wasn't installed, incorrectly. In addition
to fixing the test, generate a
"_without_optional_dependencies" wrapper around
t/20_policies.t.
Elliot Shank [Tue, 22 Jul 2008 02:37:38 +0000 (02:37 +0000)]
Bump P::C version to 1.089.
Elliot Shank [Tue, 22 Jul 2008 02:19:24 +0000 (02:19 +0000)]
Knock out RequirePodSections in 20_policy_podspelling.t.
I don't understand why but I can't knock it out in
42_perlcriticrc-tests. However, I want to get a release
out, so I'll get back to it later.
Elliot Shank [Tue, 22 Jul 2008 01:51:58 +0000 (01:51 +0000)]
Fix ProhibitPostfixControls in tests.
Elliot Shank [Mon, 21 Jul 2008 21:57:05 +0000 (21:57 +0000)]
Deal with RequireInterpolationOfMetachars in tests.
Elliot Shank [Mon, 21 Jul 2008 21:36:04 +0000 (21:36 +0000)]
Fix ProhibitEscapedMetacharacters in tests.
Elliot Shank [Mon, 21 Jul 2008 21:02:15 +0000 (21:02 +0000)]
Fix ProhibitEscapedCharacters in
20_policy_requireconsistentnewlines.t.
Elliot Shank [Mon, 21 Jul 2008 20:17:03 +0000 (20:17 +0000)]
Fix noisy strings in tests.
Elliot Shank [Mon, 21 Jul 2008 18:58:59 +0000 (18:58 +0000)]
Fix ProhibitInterpolationOfLiterals in tests.
Elliot Shank [Mon, 21 Jul 2008 18:53:24 +0000 (18:53 +0000)]
Fix RequireBracesForMultiline in 01_config_bad_perlcriticrc.t.
Elliot Shank [Mon, 21 Jul 2008 18:49:35 +0000 (18:49 +0000)]
Fix ProhibitEnumeratedClasses in 94_includes.t.
Elliot Shank [Mon, 21 Jul 2008 18:22:11 +0000 (18:22 +0000)]
Fix PodSpelling issues in tests. In t/05_utils_pod.t, I had
to "## no critic" it because I couldn't get stopwords to
work for "cperl".
Elliot Shank [Mon, 21 Jul 2008 01:39:11 +0000 (01:39 +0000)]
Add rcs_keywords option to RequireInterpolationOfMetachars.
Elliot Shank [Mon, 21 Jul 2008 01:29:14 +0000 (01:29 +0000)]
Knock out ProhibitMagicNumbers for the tests right now.
Elliot Shank [Mon, 21 Jul 2008 01:28:24 +0000 (01:28 +0000)]
POD formatting cleanups in DEVELOPER.pod and minor doc edit
in P::C::Violation.
Jeffrey Ryan Thalhammer [Tue, 15 Jul 2008 05:30:16 +0000 (05:30 +0000)]
RT #34713. Tweaked Subroutines::ProtectPrivateVars
so that "shift->_private_sub()" is allowed.
Elliot Shank [Mon, 14 Jul 2008 14:27:25 +0000 (14:27 +0000)]
Add exec to the list of things accepted by
RequireFinalReturn.
Jeffrey Ryan Thalhammer [Mon, 14 Jul 2008 05:04:47 +0000 (05:04 +0000)]
Additional stopwords for the code examples.
Jeffrey Ryan Thalhammer [Mon, 14 Jul 2008 04:55:38 +0000 (04:55 +0000)]
Subroutines::ProhibitBuiltinHomonyms now covers Perl keywords
as well. Inspired by RT #37632
Elliot Shank [Mon, 14 Jul 2008 01:25:17 +0000 (01:25 +0000)]
Change name of option in ProhibitInterpolationOfLiterals to
"allow_if_string_contains_single_quote".
Elliot Shank [Mon, 14 Jul 2008 01:14:53 +0000 (01:14 +0000)]
Fix PodSpelling problems caused by the doubling up of L< >
contents to get around the "manpage" problem.
Elliot Shank [Mon, 14 Jul 2008 01:07:08 +0000 (01:07 +0000)]
Add allow_double_quote_if_string_contains_single_quote
option to ProhibitInterpolationOfLiterals. Patch submitted
by Ed Avis (plus further edits). RT #36125.
Elliot Shank [Thu, 10 Jul 2008 21:47:28 +0000 (21:47 +0000)]
Remove documentation about the -config option to P::C::new()
so that people won't start new code that depends upon it.
Elliot Shank [Thu, 10 Jul 2008 04:51:39 +0000 (04:51 +0000)]
Fix RequireLineBoundaryMatching in 99_pod_coverage.t.
Elliot Shank [Thu, 10 Jul 2008 04:49:58 +0000 (04:49 +0000)]
Fix ProhibitPunctuationVars in tests.
Elliot Shank [Thu, 10 Jul 2008 04:30:59 +0000 (04:30 +0000)]
Fix ProhibitLocalVars in 20_policy_podspelling.t. Someone
was attempting to localize a lexical.
Elliot Shank [Thu, 10 Jul 2008 04:27:17 +0000 (04:27 +0000)]
Fix ProhibitEmptyQuotes in tests.
Elliot Shank [Thu, 10 Jul 2008 04:21:55 +0000 (04:21 +0000)]
Fix ProhibitDoubleSigils in tests.
Elliot Shank [Thu, 10 Jul 2008 04:17:40 +0000 (04:17 +0000)]
Fix RequireRcsKeywords in tests.
Elliot Shank [Thu, 10 Jul 2008 04:11:10 +0000 (04:11 +0000)]
Fix RequireCheckedClose in 05_utils.t.
Elliot Shank [Thu, 10 Jul 2008 04:06:38 +0000 (04:06 +0000)]
Fix RequireFinalReturn in 05_utils.t.
Elliot Shank [Thu, 10 Jul 2008 03:47:02 +0000 (03:47 +0000)]
The for loop TODO test for RequireFinalReturn wasn't quite
valid: You've got to name the loop variable.
Elliot Shank [Thu, 10 Jul 2008 00:02:56 +0000 (00:02 +0000)]
Add TODO test for Subroutines::RequireFinalReturn having to
do with PPI's mis-parsing of "for qw<blah> {}".
Jeffrey Ryan Thalhammer [Wed, 9 Jul 2008 19:37:30 +0000 (19:37 +0000)]
is_script() now tries to check if the filename ends in ".PL".
This prevents it from misclassifying Makefile.PL and Build.PL
and other ".PL" scripts as modules. But if the document is
coming from a pipe (rather than a file) then the filename
won't be available and is_script() will still misclassify
the file. Another approach may be to look for the absence
of a "package" statement, but I'm not sure that is very
reliable. I suspect that many newbie developers and those
with very old legacy systems may have lots of libraries that
don't have any package statements.
Elliot Shank [Wed, 9 Jul 2008 13:55:03 +0000 (13:55 +0000)]
Make -s a synonym for --single-policy.
Elliot Shank [Wed, 9 Jul 2008 05:06:12 +0000 (05:06 +0000)]
Fix RequireCheckedClose in tests.
Elliot Shank [Wed, 9 Jul 2008 04:57:51 +0000 (04:57 +0000)]
Knock out RegularExpressions::ProhibitComplexRegexes and
ErrorHandling::RequireCheckingReturnValueOfEval for tests.
Elliot Shank [Wed, 9 Jul 2008 04:44:47 +0000 (04:44 +0000)]
Finish fixing RequireExtendedFormatting problems.
Elliot Shank [Wed, 9 Jul 2008 04:32:51 +0000 (04:32 +0000)]
More RequireExtendedFormatting fixes in tests.
Elliot Shank [Wed, 9 Jul 2008 04:20:35 +0000 (04:20 +0000)]
Fix RequireExtendedFormatting in
01_config_bad_perlcriticrc.t.
Elliot Shank [Wed, 9 Jul 2008 04:17:06 +0000 (04:17 +0000)]
Fix RequireExtendedFormatting in 01_config.t.
Elliot Shank [Wed, 9 Jul 2008 03:21:36 +0000 (03:21 +0000)]
Fix the last of the RequireTestLabels problems.
Jeffrey Ryan Thalhammer [Wed, 9 Jul 2008 00:32:42 +0000 (00:32 +0000)]
Fixed typo in the code for setting the criticism-fatal option. Damn I hate
all this shennanigans with hyphens and underscores.
Elliot Shank [Tue, 8 Jul 2008 16:41:12 +0000 (16:41 +0000)]
Update class diagram to mark more classes as public.
Elliot Shank [Tue, 8 Jul 2008 15:56:40 +0000 (15:56 +0000)]
Fix RequireTestLabels in 09_theme.t.
Elliot Shank [Tue, 8 Jul 2008 14:52:39 +0000 (14:52 +0000)]
Add --list output formatting to TODO.pod.
Elliot Shank [Tue, 8 Jul 2008 05:48:50 +0000 (05:48 +0000)]
Fix RequireTestLabels problems in 02_policy.t.
Elliot Shank [Tue, 8 Jul 2008 05:44:13 +0000 (05:44 +0000)]
Finish RequireTestLabels fixes in 10_userprofile.t.
Elliot Shank [Tue, 8 Jul 2008 05:28:46 +0000 (05:28 +0000)]
Fix ProhibitAmpersandSigils in the "sort &foo(...)" case.
Elliot Shank [Tue, 8 Jul 2008 05:21:15 +0000 (05:21 +0000)]
Revert ProhibitParensWithBuiltins test change. I was looking
at the problem wrong.
Elliot Shank [Tue, 8 Jul 2008 02:37:50 +0000 (02:37 +0000)]
Failing "(caller(0))[3]" test for
ProhibitParensWithBuiltins.
Elliot Shank [Tue, 8 Jul 2008 01:08:08 +0000 (01:08 +0000)]
Failing test for ProhibitAmpersandSigils with sort.
Elliot Shank [Mon, 7 Jul 2008 16:09:13 +0000 (16:09 +0000)]
Convert L<Some::Module> escapes to
L<Some::Module|Some::Module> in response to RT #37485.
Chris Dolan [Mon, 7 Jul 2008 04:59:20 +0000 (04:59 +0000)]
Fix false positive in ProhibitSingleCharAlternation