Login
gknop/Perl-Critic.git
12 years agoDelete META.yml, MANIFEST, and README. Just have them
Elliot Shank [Sun, 18 May 2008 22:29:46 +0000 (22:29 +0000)] 
Delete META.yml, MANIFEST, and README.  Just have them
generated.

12 years agoWeird failure on Windows with PolicySummary.pod.PL. Even
Elliot Shank [Sun, 18 May 2008 22:27:54 +0000 (22:27 +0000)] 
Weird failure on Windows with PolicySummary.pod.PL.  Even
though file-name variable is simply assigned a string, the
open is complaining about attempting to open a coderef.
While forward slashes are legal on Windows, changing to
using File::Spec::catfile() just to see what happens.

12 years agoRemove duplicate "Theme" section in DEVELOPER.pod.
Elliot Shank [Sun, 18 May 2008 09:01:23 +0000 (09:01 +0000)] 
Remove duplicate "Theme" section in DEVELOPER.pod.

12 years agoFix link in DEVELOPER.pod.
Elliot Shank [Sun, 18 May 2008 08:59:18 +0000 (08:59 +0000)] 
Fix link in DEVELOPER.pod.

12 years agoRegenerate P::C README.
Elliot Shank [Sun, 18 May 2008 08:59:04 +0000 (08:59 +0000)] 
Regenerate P::C README.

12 years agoWherps. The META.yml with the version bump didn't make it
Elliot Shank [Sun, 18 May 2008 07:20:59 +0000 (07:20 +0000)] 
Wherps.  The META.yml with the version bump didn't make it
in previously.

12 years agoNever gave ProhibitMagicNumbers a proper abstract. It had
Elliot Shank [Sun, 18 May 2008 07:10:18 +0000 (07:10 +0000)] 
Never gave ProhibitMagicNumbers a proper abstract.  It had
one copied from another policy.

12 years agoBump P::C version to 1.083_003. v1.083_003
Elliot Shank [Sun, 18 May 2008 01:03:55 +0000 (01:03 +0000)] 
Bump P::C version to 1.083_003.

12 years agoEven more fun getting detection of policy load paths
Elliot Shank [Sun, 18 May 2008 00:59:52 +0000 (00:59 +0000)] 
Even more fun getting detection of policy load paths
correct.

12 years agoUpdate changes.
Elliot Shank [Sun, 18 May 2008 00:08:45 +0000 (00:08 +0000)] 
Update changes.

12 years agoWho knew that generating the PolicySummary was so fraught
Elliot Shank [Sun, 18 May 2008 00:05:10 +0000 (00:05 +0000)] 
Who knew that generating the PolicySummary was so fraught
with dangers?  We need to handle the case where the build
tool has not yet added blib/blah to @INC.

12 years agoAdd TODO for Variables::ProhibitPunctuationVars to look
Elliot Shank [Sat, 17 May 2008 17:25:37 +0000 (17:25 +0000)] 
Add TODO for Variables::ProhibitPunctuationVars to look
inside strings.  RT #35970.

12 years agoGrrr. Left debugging code in. v1.083_002
Elliot Shank [Sat, 17 May 2008 06:19:24 +0000 (06:19 +0000)] 
Grrr.  Left debugging code in.

12 years agoThe combination of M::B not copying empty directories and
Elliot Shank [Sat, 17 May 2008 06:18:24 +0000 (06:18 +0000)] 
The combination of M::B not copying empty directories and
the move of the author tests to the xt directory was causing
the test wrapper generation to fall over.  This didn't cause
any test or installation failures; it just looked bad.

12 years agoUpdate Changes.
Elliot Shank [Sat, 17 May 2008 05:28:38 +0000 (05:28 +0000)] 
Update Changes.

12 years agoBump version to 1.083_002. I want to get test reports with
Elliot Shank [Sat, 17 May 2008 05:26:31 +0000 (05:26 +0000)] 
Bump version to 1.083_002.  I want to get test reports with
PPI 1.203.

12 years agoTODO entry for policies related to '==' vs. '='
Chris Dolan [Wed, 14 May 2008 06:55:33 +0000 (06:55 +0000)] 
TODO entry for policies related to '==' vs. '='

12 years agoBump PPI version requirement to 1.203.
Elliot Shank [Wed, 14 May 2008 05:52:09 +0000 (05:52 +0000)] 
Bump PPI version requirement to 1.203.

12 years agoFix ControlStructures::ProhibitLabelsWithSpecialBlockNames'
Elliot Shank [Wed, 14 May 2008 03:08:28 +0000 (03:08 +0000)] 
Fix ControlStructures::ProhibitLabelsWithSpecialBlockNames'
dealing with whitespace between the label and the following
colon.

12 years agoRename Defaults to OptionsProcessor because that's what it
Elliot Shank [Sun, 11 May 2008 23:20:30 +0000 (23:20 +0000)] 
Rename Defaults to OptionsProcessor because that's what it
does and "Defaults" is confusing as anything.

12 years agoExempt STD(IN|OUT|ERR) from RequireBriefOpen.
Elliot Shank [Sun, 11 May 2008 22:44:01 +0000 (22:44 +0000)] 
Exempt STD(IN|OUT|ERR) from RequireBriefOpen.

12 years agoUpdate class diagram, including potential core-class
Elliot Shank [Sun, 11 May 2008 21:00:35 +0000 (21:00 +0000)] 
Update class diagram, including potential core-class
reorganization.

12 years agoFinish up ProhibitLabelsWithSpecialBlockNames.
Elliot Shank [Fri, 9 May 2008 02:43:59 +0000 (02:43 +0000)] 
Finish up ProhibitLabelsWithSpecialBlockNames.

12 years agoAdd link to Perl Buzz article in
Elliot Shank [Thu, 8 May 2008 16:29:35 +0000 (16:29 +0000)] 
Add link to Perl Buzz article in
ProhibitLabelsWithSpecialBlockNames.

12 years agoNeeded to tack on a bit more to Mike's credit.
Elliot Shank [Thu, 8 May 2008 04:14:48 +0000 (04:14 +0000)] 
Needed to tack on a bit more to Mike's credit.

12 years agoInitial implementation of
Elliot Shank [Thu, 8 May 2008 03:04:12 +0000 (03:04 +0000)] 
Initial implementation of
ControlStructures::ProhibitLabelsWithSpecialBlockNames.
Doesn't pass tests yet.

12 years agoMore TODOs.
Elliot Shank [Thu, 8 May 2008 00:12:31 +0000 (00:12 +0000)] 
More TODOs.

12 years agoAdd TODO from Andy about a policy about not using
Elliot Shank [Wed, 7 May 2008 23:45:30 +0000 (23:45 +0000)] 
Add TODO from Andy about a policy about not using
"BEGIN:{}", etc. labels.

12 years agoMore whacking on DEVELOPER.pod.
Elliot Shank [Mon, 5 May 2008 04:56:33 +0000 (04:56 +0000)] 
More whacking on DEVELOPER.pod.

12 years agoAdd meta_merge to most of the distributions. For the
Elliot Shank [Mon, 5 May 2008 01:57:39 +0000 (01:57 +0000)] 
Add meta_merge to most of the distributions.  For the
repository, point at the individual distributions'
subdirectories.

12 years agoChange text of the CONFIGURATION section for the non-
Elliot Shank [Mon, 5 May 2008 00:38:59 +0000 (00:38 +0000)] 
Change text of the CONFIGURATION section for the non-
configurable Policies.

12 years agoUpdate MANIFEST.
Elliot Shank [Mon, 5 May 2008 00:33:57 +0000 (00:33 +0000)] 
Update MANIFEST.

12 years agoMake sure all Policies have a CONFIGURATION POD section.
Elliot Shank [Mon, 5 May 2008 00:28:41 +0000 (00:28 +0000)] 
Make sure all Policies have a CONFIGURATION POD section.

12 years agoAdd an AFFILIATION POD section to all the Policies.
Elliot Shank [Sun, 4 May 2008 23:53:22 +0000 (23:53 +0000)] 
Add an AFFILIATION POD section to all the Policies.

12 years agoFix tests that broke as a result of Config now throwing an
Elliot Shank [Sun, 4 May 2008 23:52:15 +0000 (23:52 +0000)] 
Fix tests that broke as a result of Config now throwing an
exception when there are no enabled policies.

12 years agoRequire all Policies to have an AFFILIATION POD section.
Elliot Shank [Sun, 4 May 2008 22:25:51 +0000 (22:25 +0000)] 
Require all Policies to have an AFFILIATION POD section.

12 years agoCheck that there's at least one Policy enabled.
Elliot Shank [Sun, 4 May 2008 22:25:04 +0000 (22:25 +0000)] 
Check that there's at least one Policy enabled.

12 years agoRe-enable POD test in 95_kwalitee.t. Whatever has changed
Elliot Shank [Sun, 4 May 2008 21:08:29 +0000 (21:08 +0000)] 
Re-enable POD test in 95_kwalitee.t.  Whatever has changed
in our documentation now seems to not cause complaints any
more.

12 years agoUpdate MANIFEST.
Elliot Shank [Sun, 4 May 2008 21:07:13 +0000 (21:07 +0000)] 
Update MANIFEST.

12 years agoGet explicit on all dependencies, including core ones, in
Elliot Shank [Sun, 4 May 2008 21:06:07 +0000 (21:06 +0000)] 
Get explicit on all dependencies, including core ones, in
Build.PL and Makefile.PL.

12 years agoChange ProhibitMagicNumbers to allow constant subroutines.
Elliot Shank [Sun, 4 May 2008 17:18:31 +0000 (17:18 +0000)] 
Change ProhibitMagicNumbers to allow constant subroutines.

12 years agoConvert 20_policy_prohibitmagicnumbers.t to
Elliot Shank [Sun, 4 May 2008 16:24:21 +0000 (16:24 +0000)] 
Convert 20_policy_prohibitmagicnumbers.t to
ProhibitMagicNumbers.run.

12 years agoDescribe default_maximum_violations_per_document() in
Elliot Shank [Sun, 4 May 2008 14:04:13 +0000 (14:04 +0000)] 
Describe default_maximum_violations_per_document() in
DEVELOPER.pod.

12 years ago*sigh* RequireBriefOpen complains when there are multi-line
Elliot Shank [Sun, 27 Apr 2008 21:14:10 +0000 (21:14 +0000)] 
*sigh* RequireBriefOpen complains when there are multi-line
statements.  The filehandles are only open for a single statement.
However, too much effort to modify the Policy.

12 years agoUse Utils::POD in Violation.
Elliot Shank [Sun, 27 Apr 2008 20:58:20 +0000 (20:58 +0000)] 
Use Utils::POD in Violation.

12 years agoUse raw abstract accessor on Policy in PolicySummary.pod.PL, instead
Elliot Shank [Sun, 27 Apr 2008 20:04:01 +0000 (20:04 +0000)] 
Use raw abstract accessor on Policy in PolicySummary.pod.PL, instead
of direct access to P::C::Utils::POD.

12 years agoEmit Policy abstract as part of the profile prototype.
Elliot Shank [Sun, 27 Apr 2008 19:57:18 +0000 (19:57 +0000)] 
Emit Policy abstract as part of the profile prototype.

12 years agoOverexpand P::C::Utils::POD.
Elliot Shank [Sun, 27 Apr 2008 19:52:06 +0000 (19:52 +0000)] 
Overexpand P::C::Utils::POD.

12 years agoSimplify inc/Perl/Critic/BuildUtilities.pm
Elliot Shank [Sat, 26 Apr 2008 20:37:42 +0000 (20:37 +0000)] 
Simplify inc/Perl/Critic/BuildUtilities.pm

12 years agoAdd todo for the old swswsw policy suggestion.
Elliot Shank [Sat, 26 Apr 2008 20:37:05 +0000 (20:37 +0000)] 
Add todo for the old swswsw policy suggestion.

12 years agoUpdate MANIFEST and META.yml.
Elliot Shank [Fri, 25 Apr 2008 06:09:18 +0000 (06:09 +0000)] 
Update MANIFEST and META.yml.

12 years agoWhat the hell was I thinking? Remove C-style comment from
Elliot Shank [Mon, 21 Apr 2008 05:45:47 +0000 (05:45 +0000)] 
What the hell was I thinking?  Remove C-style comment from
Utils::POD.

12 years agoGenerate P::C::PolicySummary, rather than have to maintain
Elliot Shank [Mon, 21 Apr 2008 05:21:18 +0000 (05:21 +0000)] 
Generate P::C::PolicySummary, rather than have to maintain
it.

Nice that there was already a test in place to make sure
that I got it correct.  :]

12 years agoFix missing documentation and self-compliance issues in
Elliot Shank [Mon, 21 Apr 2008 05:18:47 +0000 (05:18 +0000)] 
Fix missing documentation and self-compliance issues in
Utils::POD.

12 years agoTest P::C::Utils::shebang_line() in t/05_utils.t.
Elliot Shank [Mon, 21 Apr 2008 05:16:45 +0000 (05:16 +0000)] 
Test P::C::Utils::shebang_line() in t/05_utils.t.

12 years agoFix 80_policysummary.t in the fail to open PolicySummary.pod
Elliot Shank [Mon, 21 Apr 2008 05:15:46 +0000 (05:15 +0000)] 
Fix 80_policysummary.t in the fail to open PolicySummary.pod
case.  In this situation, it was never declaring a plan.

12 years agoImplement Policy::_get_source_file(), to, well, you know,
Elliot Shank [Mon, 21 Apr 2008 05:13:43 +0000 (05:13 +0000)] 
Implement Policy::_get_source_file(), to, well, you know,
find the source code for the Policy itself.

12 years agoWeird PPI crud going on. Policy indirectly invokes
Elliot Shank [Mon, 21 Apr 2008 05:12:02 +0000 (05:12 +0000)] 
Weird PPI crud going on.  Policy indirectly invokes
P::C::Utils::shebang_line().  PPI::D->find_first(comment)
actually returns the second.  However, if I invoked
shebang_line() from the command line on the same file, PPI
corretly returns the first comment.

Changed shebang_line() to grab the first element in the
document and see whether it's a comment.

12 years agoFix mis-copied description in ProhibitCascadingIfElse.
Elliot Shank [Mon, 21 Apr 2008 05:08:02 +0000 (05:08 +0000)] 
Fix mis-copied description in ProhibitCascadingIfElse.

12 years agoAdd allow_all_brackets to
Elliot Shank [Mon, 21 Apr 2008 04:19:48 +0000 (04:19 +0000)] 
Add allow_all_brackets to
RegularExpressions::RequireBracesForMultiline in
xt/author/40_perlcriticrc.

12 years agoImplement get_module_abstract_*().
Elliot Shank [Sun, 20 Apr 2008 02:36:35 +0000 (02:36 +0000)] 
Implement get_module_abstract_*().

12 years agoFix spelling issues that showed up due to the copying of
Elliot Shank [Sun, 20 Apr 2008 00:49:30 +0000 (00:49 +0000)] 
Fix spelling issues that showed up due to the copying of
Policy descriptions.

12 years agoFix a couple mis-copied Policy descriptions.
Elliot Shank [Sun, 20 Apr 2008 00:41:02 +0000 (00:41 +0000)] 
Fix a couple mis-copied Policy descriptions.

12 years agoLet's see how this one goes over.
Elliot Shank [Sun, 20 Apr 2008 00:36:58 +0000 (00:36 +0000)] 
Let's see how this one goes over.

Following the Oslo QA hackathon where it was "officially"
decided to support the xt directory, dump the use of the
environment variable for author tests in favor of the
xt/author directory and a testauthor target in Build.PL.

12 years agoInitial P::C::Utils::POD implementation.
Elliot Shank [Sat, 19 Apr 2008 23:20:56 +0000 (23:20 +0000)] 
Initial P::C::Utils::POD implementation.

12 years agoCreate tools/svnkeywords to make setting the correct value
Elliot Shank [Sat, 19 Apr 2008 23:15:37 +0000 (23:15 +0000)] 
Create tools/svnkeywords to make setting the correct value
for the svn:keywords property simpler.

12 years agoCopy descriptions from PolicySummary to Variables::*.
Elliot Shank [Sat, 19 Apr 2008 19:49:45 +0000 (19:49 +0000)] 
Copy descriptions from PolicySummary to Variables::*.

12 years agoCopy descriptions from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 19:41:49 +0000 (19:41 +0000)] 
Copy descriptions from PolicySummary to
ValuesAndExpressions::*.

12 years agoCopy descriptions from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 19:35:20 +0000 (19:35 +0000)] 
Copy descriptions from PolicySummary to
TestingAndDebugging::*.

12 years agoCopy descriptions from PolicySummary to Subroutines::*.
Elliot Shank [Sat, 19 Apr 2008 19:31:20 +0000 (19:31 +0000)] 
Copy descriptions from PolicySummary to Subroutines::*.

12 years agoCopy descriptions from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 19:26:58 +0000 (19:26 +0000)] 
Copy descriptions from PolicySummary to
RegularExpressions::*.

12 years agoCopy description from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 19:22:25 +0000 (19:22 +0000)] 
Copy description from PolicySummary to
References::ProhibitDoubleSigils.

12 years agoCopy descriptions from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 19:20:49 +0000 (19:20 +0000)] 
Copy descriptions from PolicySummary to
NamingConventions::*.

12 years agoChange documentation for Policies with a default maximum
Elliot Shank [Sat, 19 Apr 2008 19:18:20 +0000 (19:18 +0000)] 
Change documentation for Policies with a default maximum
number of violations per document to include the phrase "per
document".  :]

12 years agoCopy descriptions from PolicySummary to Modules::*.
Elliot Shank [Sat, 19 Apr 2008 19:13:23 +0000 (19:13 +0000)] 
Copy descriptions from PolicySummary to Modules::*.

12 years agoCopy descriptions from PolicySummary to Miscellanea::*.
Elliot Shank [Sat, 19 Apr 2008 19:12:37 +0000 (19:12 +0000)] 
Copy descriptions from PolicySummary to Miscellanea::*.

12 years agoCopy descriptions from PolicySummary to InputOutput::*.
Elliot Shank [Sat, 19 Apr 2008 19:01:53 +0000 (19:01 +0000)] 
Copy descriptions from PolicySummary to InputOutput::*.

12 years agoCopy description from PolicySummary to
Elliot Shank [Sat, 19 Apr 2008 18:53:50 +0000 (18:53 +0000)] 
Copy description from PolicySummary to
ErrorHandling::RequireCarping.

12 years agoCopy descriptions from PolicySummary to Documentation::*.
Elliot Shank [Sat, 19 Apr 2008 18:52:20 +0000 (18:52 +0000)] 
Copy descriptions from PolicySummary to Documentation::*.

12 years agoAdd todo about stealing ideas from Dunce::Files.
Elliot Shank [Mon, 14 Apr 2008 21:06:46 +0000 (21:06 +0000)] 
Add todo about stealing ideas from Dunce::Files.

12 years agoFix comment in TestingAndDebugging/RequireUseWarnings.run.
Elliot Shank [Mon, 14 Apr 2008 18:31:52 +0000 (18:31 +0000)] 
Fix comment in TestingAndDebugging/RequireUseWarnings.run.

12 years agoSpelling in Changes.
Elliot Shank [Mon, 14 Apr 2008 17:54:40 +0000 (17:54 +0000)] 
Spelling in Changes.

12 years agoCopy descriptions from PolicySummary to ControlStructures::*
Elliot Shank [Mon, 14 Apr 2008 05:01:11 +0000 (05:01 +0000)] 
Copy descriptions from PolicySummary to ControlStructures::*
Policies.

12 years agoCopy descriptions from PolicySummary over to CodeLayout::*
Elliot Shank [Mon, 14 Apr 2008 04:53:14 +0000 (04:53 +0000)] 
Copy descriptions from PolicySummary over to CodeLayout::*
Policies.

12 years agoCopy descriptions from PolicySummary over to the
Elliot Shank [Mon, 14 Apr 2008 04:46:21 +0000 (04:46 +0000)] 
Copy descriptions from PolicySummary over to the
ClassHierarchies::* Policies.

12 years agoCopy descriptions from PolicySummary over to the
Elliot Shank [Mon, 14 Apr 2008 04:41:46 +0000 (04:41 +0000)] 
Copy descriptions from PolicySummary over to the
BuiltinFunctions::* Policies.

12 years agoUpdate Changes to reflect the Moose::Role exemptions.
Elliot Shank [Mon, 14 Apr 2008 02:17:58 +0000 (02:17 +0000)] 
Update Changes to reflect the Moose::Role exemptions.

12 years agoAdd Moose::Role excemptions to RequireUseStrict and
Elliot Shank [Mon, 14 Apr 2008 02:16:24 +0000 (02:16 +0000)] 
Add Moose::Role excemptions to RequireUseStrict and
RequireUseWarnings.

12 years agoOooh. Bad Elliot. Didn't update Makefile.PL when I added v1.083_001
Elliot Shank [Mon, 14 Apr 2008 01:50:48 +0000 (01:50 +0000)] 
Oooh.  Bad Elliot.  Didn't update Makefile.PL when I added
version to the dependencies in Build.PL.

12 years agoDump the code formatting of the PHILOSOPHY sestion in
Elliot Shank [Mon, 14 Apr 2008 01:48:42 +0000 (01:48 +0000)] 
Dump the code formatting of the PHILOSOPHY sestion in
Perl::Critic.  It's not code; it shouldn't look like it.  We
can put I<> around it if we want it to stand out.

Also, sync the PREREQUISITES section with Build.PL.

12 years agoRegenerate P::C's MANIFEST and META.yml.
Elliot Shank [Mon, 14 Apr 2008 01:29:45 +0000 (01:29 +0000)] 
Regenerate P::C's MANIFEST and META.yml.

12 years agoAdd t/01_policy_config.t to the list of tests that need to
Elliot Shank [Mon, 14 Apr 2008 01:28:17 +0000 (01:28 +0000)] 
Add t/01_policy_config.t to the list of tests that need to
have a module-hiding wrapper generated for it.

12 years agoUpdate Changes.
Elliot Shank [Mon, 14 Apr 2008 01:20:16 +0000 (01:20 +0000)] 
Update Changes.

12 years agoRegenerate P::C READM.
Elliot Shank [Mon, 14 Apr 2008 01:17:05 +0000 (01:17 +0000)] 
Regenerate P::C READM.

12 years agoBump P::C version to 1.083_001.
Elliot Shank [Mon, 14 Apr 2008 01:15:13 +0000 (01:15 +0000)] 
Bump P::C version to 1.083_001.

12 years agoAdd version information to the POD files.
Elliot Shank [Mon, 14 Apr 2008 01:09:40 +0000 (01:09 +0000)] 
Add version information to the POD files.

12 years agoRemove the "IMPORTANT CHANGES" section in Perl::Critic. I
Elliot Shank [Mon, 14 Apr 2008 01:03:22 +0000 (01:03 +0000)] 
Remove the "IMPORTANT CHANGES" section in Perl::Critic.  I
highly doubt many people care about v0.11 any more.  Also,
it was preventing me from using Perl::Version on the code.

12 years agoRemove PolicyConfig todo.
Elliot Shank [Mon, 14 Apr 2008 00:39:07 +0000 (00:39 +0000)] 
Remove PolicyConfig todo.

12 years agoActually use PolicyConfig.
Elliot Shank [Mon, 14 Apr 2008 00:38:00 +0000 (00:38 +0000)] 
Actually use PolicyConfig.

12 years agoCreate P::C::PolicyConfig.
Elliot Shank [Sun, 13 Apr 2008 22:15:36 +0000 (22:15 +0000)] 
Create P::C::PolicyConfig.