Login
gknop/Perl-Critic.git
13 years agosvn merge -r 2029:2018 ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL
Jeffrey Ryan Thalhammer [Mon, 10 Dec 2007 07:19:04 +0000 (07:19 +0000)] 
svn merge -r 2029:2018 ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL

Rolling back revision 2029 because Elliot cringed.

13 years agoI didn't like all the "\$foo" in the templates for the run files, so I
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 06:10:23 +0000 (06:10 +0000)] 
I didn't like all the "\$foo" in the templates for the run files, so I
changed the HEREDOCs to be literals and used a regex to substitute the
operator in the template.

13 years agoUpdated Changes log with latest bug fixes
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 05:19:58 +0000 (05:19 +0000)] 
Updated Changes log with latest bug fixes

13 years agoAdded failing test case for RT #30388. I'm not sure how
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 04:35:56 +0000 (04:35 +0000)] 
Added failing test case for RT #30388.  I'm not sure how
we'll fix this, so perhaps it will just become a TODO test.

13 years agoAdded test cases and fixed RT #31281 concerning
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 04:23:35 +0000 (04:23 +0000)] 
Added test cases and fixed RT #31281 concerning
undetected shebang lines.

13 years agoRemove 97_spelling.t from MANIFEST, now that it has been
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 04:21:53 +0000 (04:21 +0000)] 
Remove 97_spelling.t from MANIFEST, now that it has been
removed from the build.

13 years agoUse the "core" theme to disable non-native policies
Jeffrey Ryan Thalhammer [Sun, 9 Dec 2007 03:24:48 +0000 (03:24 +0000)] 
Use the "core" theme to disable non-native policies
when running 40_perlcritic.t.  This is easier than
having to list each of those policies separately.

13 years agoAdd failing tests for ProhibitCommaSeparatedStatements from
Elliot Shank [Sat, 8 Dec 2007 15:56:15 +0000 (15:56 +0000)] 
Add failing tests for ProhibitCommaSeparatedStatements from
RT #27654.

13 years ago* Add $TEST_AUTHOR_PERL_CRITIC as another TEST_AUTHOR flag so I can
Chris Dolan [Wed, 5 Dec 2007 03:51:24 +0000 (03:51 +0000)] 
* Add $TEST_AUTHOR_PERL_CRITIC as another TEST_AUTHOR flag so I can
  set it in my .cshrc once and for all
* Remove t/97_spelling.t because it's redundant with Documentation::PodSpelling
* Fix spelling: HEREDOCS -> HEREDOCs

13 years agoDon't complain about m/\#/x
Chris Dolan [Mon, 19 Nov 2007 05:02:55 +0000 (05:02 +0000)] 
Don't complain about m/\#/x

13 years agoAdd an exception for Test::More's idiom:
Chris Dolan [Fri, 16 Nov 2007 07:00:05 +0000 (07:00 +0000)] 
Add an exception for Test::More's idiom:
   local $TODO = 'some message';

13 years agoBump P::C version to 1.080.
Elliot Shank [Mon, 12 Nov 2007 03:48:21 +0000 (03:48 +0000)] 
Bump P::C version to 1.080.

13 years agoUpdate Changes.
Elliot Shank [Mon, 12 Nov 2007 03:41:19 +0000 (03:41 +0000)] 
Update Changes.

13 years agoRemove unused "use Carp" from ProfilePrototype.
Elliot Shank [Mon, 12 Nov 2007 03:34:19 +0000 (03:34 +0000)] 
Remove unused "use Carp" from ProfilePrototype.

13 years agoFix page number, RE: rt #30388
Chris Dolan [Fri, 2 Nov 2007 01:22:06 +0000 (01:22 +0000)] 
Fix page number, RE: rt #30388

13 years agoChange P::C::Policy to use exceptions.
Elliot Shank [Wed, 31 Oct 2007 04:31:18 +0000 (04:31 +0000)] 
Change P::C::Policy to use exceptions.

13 years agoMake P::C::Utils use exceptions.
Elliot Shank [Tue, 30 Oct 2007 15:55:13 +0000 (15:55 +0000)] 
Make P::C::Utils use exceptions.

13 years agoMake Violation use exceptions.
Elliot Shank [Tue, 30 Oct 2007 15:46:13 +0000 (15:46 +0000)] 
Make Violation use exceptions.

13 years agoAdd "## no critic" for exceptions to the examples.
Elliot Shank [Tue, 30 Oct 2007 15:39:53 +0000 (15:39 +0000)] 
Add "## no critic" for exceptions to the examples.

13 years agoBring doc directory over from parameters branch.
Elliot Shank [Tue, 30 Oct 2007 15:32:17 +0000 (15:32 +0000)] 
Bring doc directory over from parameters branch.

13 years agoRemove tags file.
Elliot Shank [Tue, 30 Oct 2007 15:30:34 +0000 (15:30 +0000)] 
Remove tags file.

13 years agoMake PolicySummary use proper English punctuation. :]
Elliot Shank [Tue, 30 Oct 2007 15:30:06 +0000 (15:30 +0000)] 
Make PolicySummary use proper English punctuation.  :]

13 years agoRemove useless import of Carp from PolicyListing.
Elliot Shank [Tue, 30 Oct 2007 15:18:28 +0000 (15:18 +0000)] 
Remove useless import of Carp from PolicyListing.

13 years agoConvert Theme to exceptions.
Elliot Shank [Tue, 30 Oct 2007 15:13:54 +0000 (15:13 +0000)] 
Convert Theme to exceptions.

13 years agoPrepare perlcritic for exceptions.
Elliot Shank [Tue, 30 Oct 2007 15:13:27 +0000 (15:13 +0000)] 
Prepare perlcritic for exceptions.

13 years agoUpdate RequireFinalReturn POD.
Elliot Shank [Mon, 29 Oct 2007 17:16:22 +0000 (17:16 +0000)] 
Update RequireFinalReturn POD.
Add RT URL to Changes.

13 years agoAdd "require 5.006001" to Build.PL and Makefile.PL. v1.079_003
Elliot Shank [Mon, 22 Oct 2007 09:03:18 +0000 (09:03 +0000)] 
Add "require 5.006001" to Build.PL and Makefile.PL.
I'm tired of failing test reports from perl 5.5.5.

13 years agoBump P::C version to 1.079_003.
Elliot Shank [Mon, 22 Oct 2007 09:00:50 +0000 (09:00 +0000)] 
Bump P::C version to 1.079_003.

13 years agoUpdate Changes.
Elliot Shank [Mon, 22 Oct 2007 08:55:34 +0000 (08:55 +0000)] 
Update Changes.

13 years agoBump PPI version requirement to 1.201 to get rid of the
Elliot Shank [Mon, 22 Oct 2007 08:48:00 +0000 (08:48 +0000)] 
Bump PPI version requirement to 1.201 to get rid of the
annoying warning about PPI::Exception::ParserTimeout subclassing
from itself.

13 years agoMove RCS variables from the top of Changes to the bottom because
Elliot Shank [Sun, 21 Oct 2007 16:04:04 +0000 (16:04 +0000)] 
Move RCS variables from the top of Changes to the bottom because
this was causing difficulties for some automated change-file
parsing systems.

13 years agoCleanup @EXPORT_OK declarations in exception classes. Add exception
Elliot Shank [Sun, 21 Oct 2007 12:42:18 +0000 (12:42 +0000)] 
Cleanup @EXPORT_OK declarations in exception classes.  Add exception
tests to t/00_modules.t.

13 years agoBring in the exception classes. Nothing is actually done
Elliot Shank [Sun, 21 Oct 2007 12:13:08 +0000 (12:13 +0000)] 
Bring in the exception classes.  Nothing is actually done
with them yet.

13 years agoValuesAndExpressions::ProhibitLongChainsOfMethodCalls wasn't
Elliot Shank [Sun, 21 Oct 2007 11:44:18 +0000 (11:44 +0000)] 
ValuesAndExpressions::ProhibitLongChainsOfMethodCalls wasn't
resetting chain length when it ran into the end of a
sub-expression.

http://rt.cpan.org/Public/Bug/Display.html?id=30040

13 years agoWell, that was interesting.
Elliot Shank [Sun, 21 Oct 2007 10:56:24 +0000 (10:56 +0000)] 
Well, that was interesting.

PPI::Structure::List can now contain multiple children,
so P::C::Utils::parse_arg_list() needs to handle it.

This was done in the process of fixing
http://rt.cpan.org/Ticket/Display.html?id=24924.

13 years agoBump P::C version number to 1.079_002. Will be making development v1.079_002
Elliot Shank [Sun, 21 Oct 2007 08:46:24 +0000 (08:46 +0000)] 
Bump P::C version number to 1.079_002.  Will be making development
release in order to get more testing under PPI 1.200.

13 years agoAdd TODO for allowing color output through a pipe.
Elliot Shank [Sun, 21 Oct 2007 08:28:58 +0000 (08:28 +0000)] 
Add TODO for allowing color output through a pipe.

13 years agoWhoops. In r1977, the PPI optimization in
Elliot Shank [Sun, 21 Oct 2007 08:17:41 +0000 (08:17 +0000)] 
Whoops.  In r1977, the PPI optimization in
ValuesAndExpressions::RequireNumberSeparators got taken
completely out, instead of just de-conditionalized.

14 years agoFix typos in the parameter to English in a couple tests.
Elliot Shank [Fri, 19 Oct 2007 14:21:23 +0000 (14:21 +0000)] 
Fix typos in the parameter to English in a couple tests.
Noticed by Ovid.

14 years agoAck! tools/ppidump was not being distributed!
Elliot Shank [Thu, 18 Oct 2007 21:20:57 +0000 (21:20 +0000)] 
Ack! tools/ppidump was not being distributed!

14 years agoRemove mentions of fixed PPI bugs from TODO.pod.
Elliot Shank [Mon, 15 Oct 2007 06:35:43 +0000 (06:35 +0000)] 
Remove mentions of fixed PPI bugs from TODO.pod.

14 years agoUncomment code from t/ClassHierarchies/ProhibitOneArgBless.run
Elliot Shank [Mon, 15 Oct 2007 06:25:54 +0000 (06:25 +0000)] 
Uncomment code from t/ClassHierarchies/ProhibitOneArgBless.run
that previously would not pass due to PPI problems.

14 years agoRemove PPI workarounds from
Elliot Shank [Mon, 15 Oct 2007 06:17:04 +0000 (06:17 +0000)] 
Remove PPI workarounds from
TestingAndDebugging::RequireUse{Strict|Warnings}.

14 years agoRemove PPI workaround from
Elliot Shank [Mon, 15 Oct 2007 06:11:22 +0000 (06:11 +0000)] 
Remove PPI workaround from
ValuesAndExpressions::ProhibitMismatchedOperators.

14 years agoRemove PPI workaround from
Elliot Shank [Mon, 15 Oct 2007 06:07:35 +0000 (06:07 +0000)] 
Remove PPI workaround from
ValuesAndExpressions::RequireNumberSeparators.

14 years agoRemove PPI workaround from Variables::RequireNegativeIndices.
Elliot Shank [Mon, 15 Oct 2007 06:03:44 +0000 (06:03 +0000)] 
Remove PPI workaround from Variables::RequireNegativeIndices.

14 years agoRemove TODO from
Elliot Shank [Mon, 15 Oct 2007 06:00:52 +0000 (06:00 +0000)] 
Remove TODO from
t/Variables/RequireLocalizedPunctuationVars.run.PL.

14 years agoRemove PPI workaround from
Elliot Shank [Mon, 15 Oct 2007 05:57:27 +0000 (05:57 +0000)] 
Remove PPI workaround from
t/Variables/RequireLocalizedPunctuationVars.run.PL.

14 years agoRemove PPI workaround in Modules::RequireExplicitPackage.
Elliot Shank [Mon, 15 Oct 2007 05:51:47 +0000 (05:51 +0000)] 
Remove PPI workaround in Modules::RequireExplicitPackage.

14 years agoFix in ValuesAndExpressions::ProhibitCommaSeparatedStatements
Elliot Shank [Mon, 15 Oct 2007 05:38:21 +0000 (05:38 +0000)] 
Fix in ValuesAndExpressions::ProhibitCommaSeparatedStatements
for RT #27654.

Also, removed PPI hash constructor workaround.

14 years agoAdd failing test for ValuesAndExpressions::ProhibitCommaSeparatedStatements
Elliot Shank [Mon, 15 Oct 2007 05:06:22 +0000 (05:06 +0000)] 
Add failing test for ValuesAndExpressions::ProhibitCommaSeparatedStatements
for RT #27654.

14 years agoChange required PPI version to 1.200. Marked tests as no-longer
Elliot Shank [Mon, 15 Oct 2007 04:56:18 +0000 (04:56 +0000)] 
Change required PPI version to 1.200.  Marked tests as no-longer
TODO.

14 years agoFixed misplaced stopwords list
Jeffrey Ryan Thalhammer [Wed, 10 Oct 2007 07:23:46 +0000 (07:23 +0000)] 
Fixed misplaced stopwords list

14 years agoCreate 1.079_001 version in order to test the Solaris check. v1.079_001
Elliot Shank [Tue, 9 Oct 2007 17:47:42 +0000 (17:47 +0000)] 
Create 1.079_001 version in order to test the Solaris check.

14 years agoNote Solaris check in Changes.
Elliot Shank [Tue, 9 Oct 2007 15:53:37 +0000 (15:53 +0000)] 
Note Solaris check in Changes.

14 years agoAdd Devel-CheckOS to the inc directory and use it to warn about tar
Elliot Shank [Tue, 9 Oct 2007 15:50:28 +0000 (15:50 +0000)] 
Add Devel-CheckOS to the inc directory and use it to warn about tar
on Solaris.

14 years agoChange $VERSION to a string instead of a number to deal with
Elliot Shank [Fri, 5 Oct 2007 15:38:26 +0000 (15:38 +0000)] 
Change $VERSION to a string instead of a number to deal with
trailing zeros and underscores.

14 years agoFix failures when Regexp::Parser is not installed
Chris Dolan [Thu, 4 Oct 2007 11:39:10 +0000 (11:39 +0000)] 
Fix failures when Regexp::Parser is not installed

14 years agoFix regressions to regain PPI v1.118 compatibility
Chris Dolan [Thu, 4 Oct 2007 05:07:35 +0000 (05:07 +0000)] 
Fix regressions to regain PPI v1.118 compatibility

14 years agoOops
Chris Dolan [Wed, 3 Oct 2007 07:07:40 +0000 (07:07 +0000)] 
Oops

14 years agoFix the TODO tests in ProhibitMixedBooleanOperators. This should kill
Chris Dolan [Wed, 3 Oct 2007 05:55:43 +0000 (05:55 +0000)] 
Fix the TODO tests in ProhibitMixedBooleanOperators.  This should kill
off a LOT of the false positives for this policy.

14 years agoFix a few miscellaneous self violations
Chris Dolan [Wed, 3 Oct 2007 05:47:53 +0000 (05:47 +0000)] 
Fix a few miscellaneous self violations
Add a TODO test for mixed booleans inside "eval { ... }"

14 years agoFurther work on RequireLocalizedPunctuationVars.run.PL
Chris Dolan [Wed, 3 Oct 2007 05:33:11 +0000 (05:33 +0000)] 
Further work on RequireLocalizedPunctuationVars.run.PL

14 years agoReworking RequireLocalizedPunctuationVars tests in light of PPI
Chris Dolan [Wed, 3 Oct 2007 05:27:14 +0000 (05:27 +0000)] 
Reworking RequireLocalizedPunctuationVars tests in light of PPI
bugfixes and Elliot's .PL pattern

14 years agoHook ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL
Elliot Shank [Tue, 2 Oct 2007 15:31:31 +0000 (15:31 +0000)] 
Hook ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL
into Build.PL and Makefile.PL.

14 years agoGenerate
Elliot Shank [Tue, 2 Oct 2007 14:37:41 +0000 (14:37 +0000)] 
Generate
t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.

14 years agoDegrade (sort-of) gracefully is aspell is installed but aspell-en is not
Chris Dolan [Tue, 2 Oct 2007 00:43:10 +0000 (00:43 +0000)] 
Degrade (sort-of) gracefully is aspell is installed but aspell-en is not
Workaround for File::Which warning in TEST_AUTHOR mode

14 years agoMention name of unchecked function in violation description for
Chris Dolan [Sun, 30 Sep 2007 20:22:27 +0000 (20:22 +0000)] 
Mention name of unchecked function in violation description for
InputOutput::RequireCheckedSyscalls

14 years agoPer request from David Golden, allow "local" to be used in conditional statements.
Jeffrey Ryan Thalhammer [Fri, 28 Sep 2007 15:42:13 +0000 (15:42 +0000)] 
Per request from David Golden, allow "local" to be used in conditional statements.

14 years agoCode coverage
Chris Dolan [Thu, 27 Sep 2007 05:33:14 +0000 (05:33 +0000)] 
Code coverage
Discourage "$foo =~ $regexp" and encourage "$foo =~ m/$regexp/" instead

14 years agoNew policy InputOutput::RequireCheckedSyscalls
Chris Dolan [Wed, 26 Sep 2007 05:38:12 +0000 (05:38 +0000)] 
New policy InputOutput::RequireCheckedSyscalls
Less a few tweaks and rearranging, this completes my TPF grant!
We may want to adjust t/40_perlcriticrc for this new policy (to
  include more builtins to flag)

14 years agoUpdate todo.
Elliot Shank [Wed, 26 Sep 2007 05:20:07 +0000 (05:20 +0000)] 
Update todo.

14 years agoAdd todo for #line directives.
Elliot Shank [Wed, 26 Sep 2007 05:09:24 +0000 (05:09 +0000)] 
Add todo for #line directives.

14 years agoAdd exceptions for Fatal and Fatal::Exception to InputOutput::RequireCheckedOpen...
Chris Dolan [Wed, 26 Sep 2007 04:17:23 +0000 (04:17 +0000)] 
Add exceptions for Fatal and Fatal::Exception to InputOutput::RequireCheckedOpen/Close
Add smarts about qw() to parse_arg_list

14 years agoDoc error: the config parameter stop_words was misspelled
Chris Dolan [Mon, 24 Sep 2007 04:32:25 +0000 (04:32 +0000)] 
Doc error: the config parameter stop_words was misspelled

14 years agoMinor test renaming.
Elliot Shank [Mon, 24 Sep 2007 04:13:52 +0000 (04:13 +0000)] 
Minor test renaming.

14 years agoCode coverage improvements; minor code tweaks
Chris Dolan [Mon, 24 Sep 2007 02:22:44 +0000 (02:22 +0000)] 
Code coverage improvements; minor code tweaks

14 years agoNew policy InputOutput::RequireBriefOpen
Chris Dolan [Sun, 23 Sep 2007 02:25:07 +0000 (02:25 +0000)] 
New policy InputOutput::RequireBriefOpen

14 years agoRefactor to reduce complexity of violates() method in ProhibitEnumeratedClasses.pm
Chris Dolan [Sun, 23 Sep 2007 01:46:14 +0000 (01:46 +0000)] 
Refactor to reduce complexity of violates() method in ProhibitEnumeratedClasses.pm

14 years agoAdd optimizations to the regexp policies to do culling tests before
Chris Dolan [Sun, 23 Sep 2007 00:55:46 +0000 (00:55 +0000)] 
Add optimizations to the regexp policies to do culling tests before
invoking the regexp parser.

14 years agoNew policy RegularExpressions::ProhibitEnumeratedClasses
Chris Dolan [Sat, 22 Sep 2007 05:50:28 +0000 (05:50 +0000)] 
New policy RegularExpressions::ProhibitEnumeratedClasses

14 years agoTweak to ProhibitComplexRegexes so \p{IsUppercase} and the like don't
Chris Dolan [Sat, 22 Sep 2007 05:44:04 +0000 (05:44 +0000)] 
Tweak to ProhibitComplexRegexes so \p{IsUppercase} and the like don't
count against us so much.  Maybe we should count tokens instead of
characters.  Hmm...

14 years agoNew policy RegularExpressions::ProhibitEscapedMetacharacters
Chris Dolan [Fri, 21 Sep 2007 06:52:26 +0000 (06:52 +0000)] 
New policy RegularExpressions::ProhibitEscapedMetacharacters
Several changes to achieve compliance

14 years agoAdd overlooked flag for optional module
Chris Dolan [Fri, 21 Sep 2007 04:25:19 +0000 (04:25 +0000)] 
Add overlooked flag for optional module

14 years agoAdd tests to confirm that the severities are right in PolicySummary.pod
Chris Dolan [Fri, 21 Sep 2007 04:17:42 +0000 (04:17 +0000)] 
Add tests to confirm that the severities are right in PolicySummary.pod

14 years agoAdd TODO for new idea: RegularExpressions::ProhibitUnnecessaryEscapes
Chris Dolan [Fri, 21 Sep 2007 03:36:19 +0000 (03:36 +0000)] 
Add TODO for new idea: RegularExpressions::ProhibitUnnecessaryEscapes

14 years agoAdd ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
Elliot Shank [Thu, 20 Sep 2007 14:28:05 +0000 (14:28 +0000)] 
Add ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
policy.

Needs spelling fix and more tests.

14 years agoFix Pod::Spelling problem.
Elliot Shank [Thu, 20 Sep 2007 13:25:32 +0000 (13:25 +0000)] 
Fix Pod::Spelling problem.

14 years agoMerge P::C 1.078 to the 1.xxx branch.
Elliot Shank [Thu, 20 Sep 2007 13:21:57 +0000 (13:21 +0000)] 
Merge P::C 1.078 to the 1.xxx branch.

14 years agoNew policy RegularExpressions::ProhibitSingleCharAlternation
Chris Dolan [Thu, 20 Sep 2007 06:50:51 +0000 (06:50 +0000)] 
New policy RegularExpressions::ProhibitSingleCharAlternation

To accomplish this, I wrote a simple PPI wrapper around the
Regexp::Parser DOM.  The code is a little unpleasant, but I hope that
this will be internalized to PPI someday and we can delete my work.

14 years agoMerge some changes from my personal version of includes.t into the P::C version
Chris Dolan [Thu, 20 Sep 2007 06:41:43 +0000 (06:41 +0000)] 
Merge some changes from my personal version of includes.t into the P::C version

14 years agoperlcritic wasn't letting you use the %P placeholder in the verbose format specification.
Jeffrey Ryan Thalhammer [Thu, 20 Sep 2007 06:20:55 +0000 (06:20 +0000)] 
perlcritic wasn't letting you use the %P placeholder in the verbose format specification.

I should probably factor out the list of placeholders into a package var to avoid duplication.

-lThis line, and those below, will be ignored--

M    perlcritic

14 years agoFixed typo in documentation, reported as...
Jeffrey Ryan Thalhammer [Thu, 20 Sep 2007 05:40:22 +0000 (05:40 +0000)] 
Fixed typo in documentation, reported as...
http://rt.cpan.org/Ticket/Display.html?id=28646

14 years agoAdd policy that enforces checking of $EVAL_ERROR after
Elliot Shank [Tue, 18 Sep 2007 18:03:08 +0000 (18:03 +0000)] 
Add policy that enforces checking of $EVAL_ERROR after
an eval to TODO.pod.

14 years agoFix cases where I got the expanation and description of a violation
Elliot Shank [Mon, 17 Sep 2007 02:31:50 +0000 (02:31 +0000)] 
Fix cases where I got the expanation and description of a violation
reversed.

14 years agoReplace references to new() with initialize_if_enabled() in
Elliot Shank [Mon, 17 Sep 2007 02:07:48 +0000 (02:07 +0000)] 
Replace references to new() with initialize_if_enabled() in
DEVELOPER.pod.

14 years agoOops, forgot to indicate RC argument key for ProhibitComplexRegexes
Chris Dolan [Sun, 16 Sep 2007 23:48:26 +0000 (23:48 +0000)] 
Oops, forgot to indicate RC argument key for ProhibitComplexRegexes

14 years agoFalse positive for s/(foo)/$1/ in
Chris Dolan [Sun, 16 Sep 2007 23:41:58 +0000 (23:41 +0000)] 
False positive for s/(foo)/$1/ in
RegularExpressions::ProhibitUnusedCapture.  I wasn't looking at the
replace string.

Note: the implementation of the fix for this is bit quick-and-dirty.
At some point, we may wish to use a parser for interpolated strings.
Maybe that should be built into PPI, since it already has to do that
parse once.

14 years agoChange default trigger from 50 chars to 60 chars in
Chris Dolan [Sun, 16 Sep 2007 23:39:31 +0000 (23:39 +0000)] 
Change default trigger from 50 chars to 60 chars in
RegularExpressions::ProhibitComplexRegexes after trying this policy
out on some real world code.  50 was too low.

14 years agoMerge r1904-r1908, the 1.077 release, to the 1.xxx branch.
Elliot Shank [Sat, 15 Sep 2007 14:59:45 +0000 (14:59 +0000)] 
Merge r1904-r1908, the 1.077 release, to the 1.xxx branch.