Login
gknop/Perl-Critic.git
12 years agoCleaning up my trailing whitespace. Damn Eclipse. I guess nobody is perfect.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 04:36:02 +0000 (04:36 +0000)] 
Cleaning up my trailing whitespace.  Damn Eclipse.  I guess nobody is perfect.

12 years agoUndoing the patch for Schwern's capitalization policy.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 04:12:00 +0000 (04:12 +0000)] 
Undoing the patch for Schwern's capitalization policy.
We'll put this back in after the release.

12 years agoMarked some failing tests as TODO, so I can go ahead with release. Will fix these...
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 03:36:18 +0000 (03:36 +0000)] 
Marked some failing tests as TODO, so I can go ahead with release.  Will fix these later.

12 years agoFurther cleanup after moving that policy to P-C-More.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 03:19:56 +0000 (03:19 +0000)] 
Further cleanup after moving that policy to P-C-More.

12 years agoUndo Schwern's changes in the last patch to the
Elliot Shank [Thu, 28 Aug 2008 13:07:45 +0000 (13:07 +0000)] 
Undo Schwern's changes in the last patch to the
ProhibitMixedCase* policies which changed their PBP page
numbers and increased their severities from lowest to low.

He was correct in his original assessment that these
policies don't really do anything with regard to PBP section
3.5.  These do apply the rules in section 3.6, however.

Also, since these policies deal with cosmetic issues, they
should remain at the lowest severity by default.

12 years agoApply Schwern's NamingConventions::Capitalization patch from
Elliot Shank [Thu, 28 Aug 2008 13:01:05 +0000 (13:01 +0000)] 
Apply Schwern's NamingConventions::Capitalization patch from
RT #38673.

12 years agoUpdate Changes file with latest bug fix.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 17:52:05 +0000 (17:52 +0000)] 
Update Changes file with latest bug fix.

12 years agoI think I've finally fixed the problem of false-positives coming from leading tabs...
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 17:46:06 +0000 (17:46 +0000)] 
I think I've finally fixed the problem of false-positives coming from leading tabs inside qw() statements and regexes.

12 years agoUpdate TODO list.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:24:17 +0000 (03:24 +0000)] 
Update TODO list.

12 years agoUpdated changes to reflect relocation of Policy.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:06:48 +0000 (03:06 +0000)] 
Updated changes to reflect relocation of Policy.

12 years agoMoving the test case for RequireConstantOnLeftSideOfEquality too.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:02:19 +0000 (03:02 +0000)] 
Moving the test case for RequireConstantOnLeftSideOfEquality too.

12 years agoFinally decided to move RequireConstantOnLeftSideOfEquality to
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 02:59:41 +0000 (02:59 +0000)] 
Finally decided to move RequireConstantOnLeftSideOfEquality to
P-C-More.  This is just too controversial and pesky to put in the
core.  If I can come up with a better version of the policy that
actually finds real bugs (as Chris suggested), then I'll put it in
core.

12 years agoFixed ProhibitHardTabs so that it would allow leading tabs
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 11:01:13 +0000 (11:01 +0000)] 
Fixed ProhibitHardTabs so that it would allow leading tabs
in qw(), regexen, and virtually any other token.  I'm not
sure this is what we really want.  For reference,
https://rt.cpan.org/Ticket/Display.html?id=32440.  I
couldn't tell from Elliot's comments what the "correct"
solution is.  But I'm sure he'll enlighten me soon
enough.

12 years agoEnhanced the -doc feature to take advantage of the
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 08:58:14 +0000 (08:58 +0000)] 
Enhanced the -doc feature to take advantage of the
-pager feature that Schwern wrote.  To do this, I
needed to change up when the options are dashified.
Now, they are dashified immediately after GetOpt
pulls them out of @ARGV.  I think this is an
improvement because you don't have to worry
about whether the %opts hash has been dashified
yet.

12 years agoAdding an EPIC config file
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 00:40:11 +0000 (00:40 +0000)] 
Adding an EPIC config file

12 years agoDealing with more Eclipse files
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 00:12:56 +0000 (00:12 +0000)] 
Dealing with more Eclipse files

12 years agoAdded a build.xml script to all distributions. Tools like Eclipse and Intelli-J
Jeffrey Ryan Thalhammer [Sat, 23 Aug 2008 23:17:59 +0000 (23:17 +0000)] 
Added a build.xml script to all distributions.  Tools like Eclipse and Intelli-J
have good interfaces for creating and running Ant scripts.  These files
just serve as wrappers around Build.PL, so you can take advantage of those
interfaces when working with Perl dists.

12 years agoTaking premptive steps: adding my forthcoming build.xml to MANIFEST.SKIP
Jeffrey Ryan Thalhammer [Sat, 23 Aug 2008 23:07:45 +0000 (23:07 +0000)] 
Taking premptive steps: adding my forthcoming build.xml to MANIFEST.SKIP

12 years agoFix PBP page numbers in ProhibitMixedCaseVars and
Elliot Shank [Sat, 23 Aug 2008 01:19:41 +0000 (01:19 +0000)] 
Fix PBP page numbers in ProhibitMixedCaseVars and
ProhibitMixedCaseVars.

12 years agoForgot to set svn:keywords on
Elliot Shank [Fri, 22 Aug 2008 21:15:56 +0000 (21:15 +0000)] 
Forgot to set svn:keywords on
RegularExpressions::RequireDotMatchAnything.

12 years agoMake tests comply with
Elliot Shank [Fri, 22 Aug 2008 02:34:34 +0000 (02:34 +0000)] 
Make tests comply with
RegularExpressions::RequireDotMatchAnything.

12 years agoMake rest of code comply with
Elliot Shank [Fri, 22 Aug 2008 02:24:50 +0000 (02:24 +0000)] 
Make rest of code comply with
RegularExpressions::RequireDotMatchAnything.

12 years agoMake Policies comply with
Elliot Shank [Fri, 22 Aug 2008 02:07:35 +0000 (02:07 +0000)] 
Make Policies comply with
RegularExpressions::RequireDotMatchAnything.

12 years agoImplement RegularExpressions::RequireDotMatchAnything.
Elliot Shank [Fri, 22 Aug 2008 01:43:08 +0000 (01:43 +0000)] 
Implement RegularExpressions::RequireDotMatchAnything.

12 years agoCreate an option for CodeLayout::ProhibitQuotedWordLists
Elliot Shank [Fri, 22 Aug 2008 01:18:27 +0000 (01:18 +0000)] 
Create an option for CodeLayout::ProhibitQuotedWordLists
that makes it complain about word lists containing non-word
characters again.

12 years agoAdd ".project" to all of the MANIFEST.SKIP files.
Elliot Shank [Fri, 22 Aug 2008 00:51:21 +0000 (00:51 +0000)] 
Add ".project" to all of the MANIFEST.SKIP files.

12 years agoColor for high-severity violations is now magenta,
Jeffrey Ryan Thalhammer [Thu, 21 Aug 2008 01:12:07 +0000 (01:12 +0000)] 
Color for high-severity violations is now magenta,
because this looks better on typical terminals with
a white background.  RT #38511.

12 years agoAdding username for anonymous checkout from our repository.
Jeffrey Ryan Thalhammer [Thu, 21 Aug 2008 00:42:15 +0000 (00:42 +0000)] 
Adding username for anonymous checkout from our repository.
Thanks to Schwern for suggesting.  #RT 38628.

12 years agoI started using Eclipse for all my Perl work. So I am checking in the Eclipse projec...
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 06:05:09 +0000 (06:05 +0000)] 
I started using Eclipse for all my Perl work.  So I am checking in the Eclipse project files for each distro.  I am not really sure if these should be in the repository or not

12 years agoUndoing r2675. Now that the "-color" is no longer being set in _parse_command_line...
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 05:39:41 +0000 (05:39 +0000)] 
Undoing r2675.  Now that the "-color" is no longer being set in _parse_command_line(), we no longer need to worry about double dashes in the keys of the argument hash for P::C->new().  Default values for the command-line options should only be defined in the OptionsProcessor.

12 years agoAdded failing test case that came to me in the mail today.
Jeffrey Ryan Thalhammer [Tue, 19 Aug 2008 05:31:59 +0000 (05:31 +0000)] 
Added failing test case that came to me in the mail today.

12 years agoChange perlcritic to not unconditionally add a "-" to the
Elliot Shank [Sun, 17 Aug 2008 10:56:48 +0000 (10:56 +0000)] 
Change perlcritic to not unconditionally add a "-" to the
front of options to be passed to Perl::Critic::new() in
response to RT #38458.

12 years agoMake the changes to
Elliot Shank [Sun, 17 Aug 2008 10:30:08 +0000 (10:30 +0000)] 
Make the changes to
RegularExpressions::RequireExtendedFormatting more clear in
Changes.

12 years agoClean up Schwern's
Elliot Shank [Sun, 17 Aug 2008 10:18:21 +0000 (10:18 +0000)] 
Clean up Schwern's
RegularExpressions::RequireExtendedFormatting patch. Renamed
the min_regex_length option to
minimum_regex_length_to_complain_about. The way the
allow_with_whitespace was coded, if the regex contained any
whitespace at all, it was exempt. Instead, I made regexes
that only contain word characters and whitespace exempt by
default, and added a strict option.  I'm not so sure about
this one.

12 years agoApply raw patch from Schwern that adds options to
Elliot Shank [Sun, 17 Aug 2008 09:19:38 +0000 (09:19 +0000)] 
Apply raw patch from Schwern that adds options to
RegularExpressions::RequireExtendedFormatting.

12 years agoFix missing word in the ProhibitNoWarnings POD.
Elliot Shank [Sat, 16 Aug 2008 02:09:57 +0000 (02:09 +0000)] 
Fix missing word in the ProhibitNoWarnings POD.

12 years agoUpdate Changes with the new allow_with_category_restriction
Elliot Shank [Sat, 16 Aug 2008 02:03:03 +0000 (02:03 +0000)] 
Update Changes with the new allow_with_category_restriction
option for TestingAndDebugging::ProhibitNoWarnings.

12 years agoClean up both existing problems and problems with Schwern's
Elliot Shank [Sat, 16 Aug 2008 01:58:43 +0000 (01:58 +0000)] 
Clean up both existing problems and problems with Schwern's
patch in TestingAndDebugging::ProhibitNoWarnings.

12 years agoApply raw patch from Schwern for
Elliot Shank [Sat, 16 Aug 2008 01:29:27 +0000 (01:29 +0000)] 
Apply raw patch from Schwern for
TestingAndDebugging::ProhibitNoWarnings.  Needs some rework.
The special value in the allow option?  Eww.  Not too hard
to fix, though.

12 years agoClean up self compliance problems introduced by Schwern's
Elliot Shank [Thu, 14 Aug 2008 05:01:46 +0000 (05:01 +0000)] 
Clean up self compliance problems introduced by Schwern's
pager patch.  Still need to actually review the patch.  :]

12 years agoApply the unmodified patch from Schwern (modulo dealing with
Elliot Shank [Thu, 14 Aug 2008 03:58:27 +0000 (03:58 +0000)] 
Apply the unmodified patch from Schwern (modulo dealing with
RJBS' change to support PAR).  I have no idea whether tests
or anything works at this point.  I just considered it
worthwhile to capture the change as it is before modifying
it further.

12 years agoComment in P::C::Document about underscores in perl version
Elliot Shank [Thu, 14 Aug 2008 03:49:53 +0000 (03:49 +0000)] 
Comment in P::C::Document about underscores in perl version
dependencies, i.e. "use 5.008_005;".

12 years agoAdd the xt directory to no_index in Build.PL.
Elliot Shank [Wed, 13 Aug 2008 17:07:25 +0000 (17:07 +0000)] 
Add the xt directory to no_index in Build.PL.

12 years agoUpdate Changes to reflect the fix for RT #38380 that RJBS
Elliot Shank [Mon, 11 Aug 2008 20:12:20 +0000 (20:12 +0000)] 
Update Changes to reflect the fix for RT #38380 that RJBS
did.

12 years agobugfix for running under PAR, RT #38380
Ricardo Signes [Mon, 11 Aug 2008 19:54:16 +0000 (19:54 +0000)] 
bugfix for running under PAR, RT #38380

12 years agoin 20_policies.t, specify a more useful format for
Elliot Shank [Sat, 9 Aug 2008 20:49:52 +0000 (20:49 +0000)] 
in 20_policies.t, specify a more useful format for
violations that are shown when there's a test failure.

Inspired by failures in
Variables/RequireLocalizedPunctuationVars.run occurring when
running on a 5.10.0 + patches perl.

13 years agoAnother example of a problem in
Elliot Shank [Wed, 30 Jul 2008 01:49:36 +0000 (01:49 +0000)] 
Another example of a problem in
ProhibitEscapedMetacharacters with character classes.

13 years agoFailing test for
Elliot Shank [Wed, 30 Jul 2008 01:41:56 +0000 (01:41 +0000)] 
Failing test for
RegularExpressions::ProhibitEscapedMetacharacters.

13 years agoForgot to update Changes
Chris Dolan [Mon, 28 Jul 2008 02:40:25 +0000 (02:40 +0000)] 
Forgot to update Changes

13 years agoTernaries now satisfy RequireCheckingReturnValueOfEval:
Chris Dolan [Mon, 28 Jul 2008 02:39:04 +0000 (02:39 +0000)] 
Ternaries now satisfy RequireCheckingReturnValueOfEval:
  eval { require Foo; 1; } ? ok() : nok();

13 years agoDescribe policy for enforcing correct spelling of variable names.
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 23:30:53 +0000 (23:30 +0000)] 
Describe policy for enforcing correct spelling of variable names.

This all got started here: http://rt.cpan.org/Ticket/Display.html?id=37899

13 years agoFixed spelling error. RT #37899
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 23:20:48 +0000 (23:20 +0000)] 
Fixed spelling error. RT #37899

13 years agoCodeLayout::ProhibitQuotedWordLists also now applies to the
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 06:14:55 +0000 (06:14 +0000)] 
CodeLayout::ProhibitQuotedWordLists also now applies to the
import arguments of a C<use> statement.  RT #24467.

I also cleaned up some of the tests for this Policy.

Disabled RequireConstantOnLeftSideOfEquality until I decide
which distro to put that policy in.

13 years agoProhibitQuotedWordLists does not apply to lists
Jeffrey Ryan Thalhammer [Sun, 27 Jul 2008 03:35:46 +0000 (03:35 +0000)] 
ProhibitQuotedWordLists does not apply to lists
that contain non-words. RT #37886.

13 years agoAdd RT # to ProhibitPostfixControls TODO.
Elliot Shank [Thu, 24 Jul 2008 14:50:59 +0000 (14:50 +0000)] 
Add RT # to ProhibitPostfixControls TODO.

13 years agoTODO about ControlStructures::ProhibitPostfixControls
Elliot Shank [Thu, 24 Jul 2008 14:49:56 +0000 (14:49 +0000)] 
TODO about ControlStructures::ProhibitPostfixControls
changing its explanation when "do {} while" is found.

13 years agoDiddling svn:ignore.
Jeffrey Ryan Thalhammer [Wed, 23 Jul 2008 04:18:09 +0000 (04:18 +0000)] 
Diddling svn:ignore.

13 years agoAdded my first new policy in a very long time. So I might be a bit
Jeffrey Ryan Thalhammer [Wed, 23 Jul 2008 04:14:28 +0000 (04:14 +0000)] 
Added my first new policy in a very long time.  So I might be a bit
rusty here...

This is a partial implementation of the RequireConstantBeforeOperator
policy mentioned in the TODO list.  For now, it only applies to the
'==' and 'eq' operators.  But if you guys think it should be extended
to all other comparison operators, then I can do that.

13 years ago20_policies.t didn't have a "1;" at the end, so it failed to v1.090
Elliot Shank [Tue, 22 Jul 2008 14:20:39 +0000 (14:20 +0000)] 
20_policies.t didn't have a "1;" at the end, so it failed to
load in 20_policies.t_without_optional_dependencies.t.

13 years agoBump P::C version to 1.090.
Elliot Shank [Tue, 22 Jul 2008 13:47:03 +0000 (13:47 +0000)] 
Bump P::C version to 1.090.

13 years agoProhibitSingleCharAlternation test was failing when
Elliot Shank [Tue, 22 Jul 2008 13:44:20 +0000 (13:44 +0000)] 
ProhibitSingleCharAlternation test was failing when
Regexp::Parser wasn't installed, incorrectly.  In addition
to fixing the test, generate a
"_without_optional_dependencies" wrapper around
t/20_policies.t.

13 years agoBump P::C version to 1.089. v1.089
Elliot Shank [Tue, 22 Jul 2008 02:37:38 +0000 (02:37 +0000)] 
Bump P::C version to 1.089.

13 years agoKnock out RequirePodSections in 20_policy_podspelling.t.
Elliot Shank [Tue, 22 Jul 2008 02:19:24 +0000 (02:19 +0000)] 
Knock out RequirePodSections in 20_policy_podspelling.t.
I don't understand why but I can't knock it out in
42_perlcriticrc-tests.  However, I want to get a release
out, so I'll get back to it later.

13 years agoFix ProhibitPostfixControls in tests.
Elliot Shank [Tue, 22 Jul 2008 01:51:58 +0000 (01:51 +0000)] 
Fix ProhibitPostfixControls in tests.

13 years agoDeal with RequireInterpolationOfMetachars in tests.
Elliot Shank [Mon, 21 Jul 2008 21:57:05 +0000 (21:57 +0000)] 
Deal with RequireInterpolationOfMetachars in tests.

13 years agoFix ProhibitEscapedMetacharacters in tests.
Elliot Shank [Mon, 21 Jul 2008 21:36:04 +0000 (21:36 +0000)] 
Fix ProhibitEscapedMetacharacters in tests.

13 years agoFix ProhibitEscapedCharacters in
Elliot Shank [Mon, 21 Jul 2008 21:02:15 +0000 (21:02 +0000)] 
Fix ProhibitEscapedCharacters in
20_policy_requireconsistentnewlines.t.

13 years agoFix noisy strings in tests.
Elliot Shank [Mon, 21 Jul 2008 20:17:03 +0000 (20:17 +0000)] 
Fix noisy strings in tests.

13 years agoFix ProhibitInterpolationOfLiterals in tests.
Elliot Shank [Mon, 21 Jul 2008 18:58:59 +0000 (18:58 +0000)] 
Fix ProhibitInterpolationOfLiterals in tests.

13 years agoFix RequireBracesForMultiline in 01_config_bad_perlcriticrc.t.
Elliot Shank [Mon, 21 Jul 2008 18:53:24 +0000 (18:53 +0000)] 
Fix RequireBracesForMultiline in 01_config_bad_perlcriticrc.t.

13 years agoFix ProhibitEnumeratedClasses in 94_includes.t.
Elliot Shank [Mon, 21 Jul 2008 18:49:35 +0000 (18:49 +0000)] 
Fix ProhibitEnumeratedClasses in 94_includes.t.

13 years agoFix PodSpelling issues in tests. In t/05_utils_pod.t, I had
Elliot Shank [Mon, 21 Jul 2008 18:22:11 +0000 (18:22 +0000)] 
Fix PodSpelling issues in tests.  In t/05_utils_pod.t, I had
to "## no critic" it because I couldn't get stopwords to
work for "cperl".

13 years agoAdd rcs_keywords option to RequireInterpolationOfMetachars.
Elliot Shank [Mon, 21 Jul 2008 01:39:11 +0000 (01:39 +0000)] 
Add rcs_keywords option to RequireInterpolationOfMetachars.

13 years agoKnock out ProhibitMagicNumbers for the tests right now.
Elliot Shank [Mon, 21 Jul 2008 01:29:14 +0000 (01:29 +0000)] 
Knock out ProhibitMagicNumbers for the tests right now.

13 years agoPOD formatting cleanups in DEVELOPER.pod and minor doc edit
Elliot Shank [Mon, 21 Jul 2008 01:28:24 +0000 (01:28 +0000)] 
POD formatting cleanups in DEVELOPER.pod and minor doc edit
in P::C::Violation.

13 years agoRT #34713. Tweaked Subroutines::ProtectPrivateVars
Jeffrey Ryan Thalhammer [Tue, 15 Jul 2008 05:30:16 +0000 (05:30 +0000)] 
RT #34713.  Tweaked Subroutines::ProtectPrivateVars
so that "shift->_private_sub()" is allowed.

13 years agoAdd exec to the list of things accepted by
Elliot Shank [Mon, 14 Jul 2008 14:27:25 +0000 (14:27 +0000)] 
Add exec to the list of things accepted by
RequireFinalReturn.

13 years agoAdditional stopwords for the code examples.
Jeffrey Ryan Thalhammer [Mon, 14 Jul 2008 05:04:47 +0000 (05:04 +0000)] 
Additional stopwords for the code examples.

13 years agoSubroutines::ProhibitBuiltinHomonyms now covers Perl keywords
Jeffrey Ryan Thalhammer [Mon, 14 Jul 2008 04:55:38 +0000 (04:55 +0000)] 
Subroutines::ProhibitBuiltinHomonyms now covers Perl keywords
as well.  Inspired by RT #37632

13 years agoChange name of option in ProhibitInterpolationOfLiterals to
Elliot Shank [Mon, 14 Jul 2008 01:25:17 +0000 (01:25 +0000)] 
Change name of option in ProhibitInterpolationOfLiterals to
"allow_if_string_contains_single_quote".

13 years agoFix PodSpelling problems caused by the doubling up of L< >
Elliot Shank [Mon, 14 Jul 2008 01:14:53 +0000 (01:14 +0000)] 
Fix PodSpelling problems caused by the doubling up of L< >
contents to get around the "manpage" problem.

13 years agoAdd allow_double_quote_if_string_contains_single_quote
Elliot Shank [Mon, 14 Jul 2008 01:07:08 +0000 (01:07 +0000)] 
Add allow_double_quote_if_string_contains_single_quote
option to ProhibitInterpolationOfLiterals.  Patch submitted
by Ed Avis (plus further edits).  RT #36125.

13 years agoRemove documentation about the -config option to P::C::new()
Elliot Shank [Thu, 10 Jul 2008 21:47:28 +0000 (21:47 +0000)] 
Remove documentation about the -config option to P::C::new()
so that people won't start new code that depends upon it.

13 years agoFix RequireLineBoundaryMatching in 99_pod_coverage.t.
Elliot Shank [Thu, 10 Jul 2008 04:51:39 +0000 (04:51 +0000)] 
Fix RequireLineBoundaryMatching in 99_pod_coverage.t.

13 years agoFix ProhibitPunctuationVars in tests.
Elliot Shank [Thu, 10 Jul 2008 04:49:58 +0000 (04:49 +0000)] 
Fix ProhibitPunctuationVars in tests.

13 years agoFix ProhibitLocalVars in 20_policy_podspelling.t. Someone
Elliot Shank [Thu, 10 Jul 2008 04:30:59 +0000 (04:30 +0000)] 
Fix ProhibitLocalVars in 20_policy_podspelling.t.  Someone
was attempting to localize a lexical.

13 years agoFix ProhibitEmptyQuotes in tests.
Elliot Shank [Thu, 10 Jul 2008 04:27:17 +0000 (04:27 +0000)] 
Fix ProhibitEmptyQuotes in tests.

13 years agoFix ProhibitDoubleSigils in tests.
Elliot Shank [Thu, 10 Jul 2008 04:21:55 +0000 (04:21 +0000)] 
Fix ProhibitDoubleSigils in tests.

13 years agoFix RequireRcsKeywords in tests.
Elliot Shank [Thu, 10 Jul 2008 04:17:40 +0000 (04:17 +0000)] 
Fix RequireRcsKeywords in tests.

13 years agoFix RequireCheckedClose in 05_utils.t.
Elliot Shank [Thu, 10 Jul 2008 04:11:10 +0000 (04:11 +0000)] 
Fix RequireCheckedClose in 05_utils.t.

13 years agoFix RequireFinalReturn in 05_utils.t.
Elliot Shank [Thu, 10 Jul 2008 04:06:38 +0000 (04:06 +0000)] 
Fix RequireFinalReturn in 05_utils.t.

13 years agoThe for loop TODO test for RequireFinalReturn wasn't quite
Elliot Shank [Thu, 10 Jul 2008 03:47:02 +0000 (03:47 +0000)] 
The for loop TODO test for RequireFinalReturn wasn't quite
valid: You've got to name the loop variable.

13 years agoAdd TODO test for Subroutines::RequireFinalReturn having to
Elliot Shank [Thu, 10 Jul 2008 00:02:56 +0000 (00:02 +0000)] 
Add TODO test for Subroutines::RequireFinalReturn having to
do with PPI's mis-parsing of "for qw<blah> {}".

13 years agois_script() now tries to check if the filename ends in ".PL".
Jeffrey Ryan Thalhammer [Wed, 9 Jul 2008 19:37:30 +0000 (19:37 +0000)] 
is_script() now tries to check if the filename ends in ".PL".
This prevents it from misclassifying Makefile.PL and Build.PL
and other ".PL" scripts as modules.  But if the document is
coming from a pipe (rather than a file) then the filename
won't be available and is_script() will still misclassify
the file.  Another approach may be to look for the absence
of a "package" statement, but I'm not sure that is very
reliable.  I suspect that many newbie developers and those
with very old legacy systems may have lots of libraries that
don't have any package statements.

13 years agoMake -s a synonym for --single-policy.
Elliot Shank [Wed, 9 Jul 2008 13:55:03 +0000 (13:55 +0000)] 
Make -s a synonym for --single-policy.

13 years agoFix RequireCheckedClose in tests.
Elliot Shank [Wed, 9 Jul 2008 05:06:12 +0000 (05:06 +0000)] 
Fix RequireCheckedClose in tests.

13 years agoKnock out RegularExpressions::ProhibitComplexRegexes and
Elliot Shank [Wed, 9 Jul 2008 04:57:51 +0000 (04:57 +0000)] 
Knock out RegularExpressions::ProhibitComplexRegexes and
ErrorHandling::RequireCheckingReturnValueOfEval for tests.

13 years agoFinish fixing RequireExtendedFormatting problems.
Elliot Shank [Wed, 9 Jul 2008 04:44:47 +0000 (04:44 +0000)] 
Finish fixing RequireExtendedFormatting problems.

13 years agoMore RequireExtendedFormatting fixes in tests.
Elliot Shank [Wed, 9 Jul 2008 04:32:51 +0000 (04:32 +0000)] 
More RequireExtendedFormatting fixes in tests.

13 years agoFix RequireExtendedFormatting in
Elliot Shank [Wed, 9 Jul 2008 04:20:35 +0000 (04:20 +0000)] 
Fix RequireExtendedFormatting in
01_config_bad_perlcriticrc.t.