Login
gknop/Perl-Critic.git
13 years agoFixed typo in the code for setting the criticism-fatal option. Damn I hate
Jeffrey Ryan Thalhammer [Wed, 9 Jul 2008 00:32:42 +0000 (00:32 +0000)] 
Fixed typo in the code for setting the criticism-fatal option.  Damn I hate
all this shennanigans with hyphens and underscores.

13 years agoUpdate class diagram to mark more classes as public.
Elliot Shank [Tue, 8 Jul 2008 16:41:12 +0000 (16:41 +0000)] 
Update class diagram to mark more classes as public.

13 years agoFix RequireTestLabels in 09_theme.t.
Elliot Shank [Tue, 8 Jul 2008 15:56:40 +0000 (15:56 +0000)] 
Fix RequireTestLabels in 09_theme.t.

13 years agoAdd --list output formatting to TODO.pod.
Elliot Shank [Tue, 8 Jul 2008 14:52:39 +0000 (14:52 +0000)] 
Add --list output formatting to TODO.pod.

13 years agoFix RequireTestLabels problems in 02_policy.t.
Elliot Shank [Tue, 8 Jul 2008 05:48:50 +0000 (05:48 +0000)] 
Fix RequireTestLabels problems in 02_policy.t.

13 years agoFinish RequireTestLabels fixes in 10_userprofile.t.
Elliot Shank [Tue, 8 Jul 2008 05:44:13 +0000 (05:44 +0000)] 
Finish RequireTestLabels fixes in 10_userprofile.t.

13 years agoFix ProhibitAmpersandSigils in the "sort &foo(...)" case.
Elliot Shank [Tue, 8 Jul 2008 05:28:46 +0000 (05:28 +0000)] 
Fix ProhibitAmpersandSigils in the "sort &foo(...)" case.

13 years agoRevert ProhibitParensWithBuiltins test change. I was looking
Elliot Shank [Tue, 8 Jul 2008 05:21:15 +0000 (05:21 +0000)] 
Revert ProhibitParensWithBuiltins test change. I was looking
at the problem wrong.

13 years agoFailing "(caller(0))[3]" test for
Elliot Shank [Tue, 8 Jul 2008 02:37:50 +0000 (02:37 +0000)] 
Failing "(caller(0))[3]" test for
ProhibitParensWithBuiltins.

13 years agoFailing test for ProhibitAmpersandSigils with sort.
Elliot Shank [Tue, 8 Jul 2008 01:08:08 +0000 (01:08 +0000)] 
Failing test for ProhibitAmpersandSigils with sort.

13 years agoConvert L<Some::Module> escapes to
Elliot Shank [Mon, 7 Jul 2008 16:09:13 +0000 (16:09 +0000)] 
Convert L<Some::Module> escapes to
L<Some::Module|Some::Module> in response to RT #37485.

13 years agoFix false positive in ProhibitSingleCharAlternation
Chris Dolan [Mon, 7 Jul 2008 04:59:20 +0000 (04:59 +0000)] 
Fix false positive in ProhibitSingleCharAlternation

13 years agoRevert r2533 and disable Subroutines::ProtectPrivateSubs in
Elliot Shank [Mon, 7 Jul 2008 03:29:11 +0000 (03:29 +0000)] 
Revert r2533 and disable Subroutines::ProtectPrivateSubs in
42_perlcriticrc-tests.  Tests ought to be able to get at the
guts.

13 years agoFix some RequireTestLabels problems. A lot more to go yet.
Elliot Shank [Mon, 7 Jul 2008 03:13:57 +0000 (03:13 +0000)] 
Fix some RequireTestLabels problems.  A lot more to go yet.

13 years ago"## no critic" out ProtectPrivateSubs in tests.
Elliot Shank [Mon, 7 Jul 2008 02:59:51 +0000 (02:59 +0000)] 
"## no critic" out ProtectPrivateSubs in tests.

13 years agoFix ProhibitExcessMainComplexity in tests.
Elliot Shank [Mon, 7 Jul 2008 02:46:53 +0000 (02:46 +0000)] 
Fix ProhibitExcessMainComplexity in tests.

13 years agoFix ProhibitCaptureWithoutTest in 80_policysummary.t.
Elliot Shank [Mon, 7 Jul 2008 01:50:01 +0000 (01:50 +0000)] 
Fix ProhibitCaptureWithoutTest in 80_policysummary.t.

13 years agoFix RequireCarping in tests.
Elliot Shank [Mon, 7 Jul 2008 01:42:57 +0000 (01:42 +0000)] 
Fix RequireCarping in tests.

13 years agoWhoops. Didn't update Changes for the ProhibitUnusedCapture
Elliot Shank [Mon, 7 Jul 2008 01:29:50 +0000 (01:29 +0000)] 
Whoops.  Didn't update Changes for the ProhibitUnusedCapture
fix.

13 years agoProhibitUnusedCapture was missing a /g modifier on a match.
Elliot Shank [Mon, 7 Jul 2008 01:23:54 +0000 (01:23 +0000)] 
ProhibitUnusedCapture was missing a /g modifier on a match.

13 years agoFix ProhibitUnusedVariables in
Elliot Shank [Mon, 7 Jul 2008 01:10:37 +0000 (01:10 +0000)] 
Fix ProhibitUnusedVariables in
20_policy_prohibittrailingwhitespace.t.

13 years ago"## no critic" out RequireBriefOpen in tests.
Elliot Shank [Mon, 7 Jul 2008 01:08:26 +0000 (01:08 +0000)] 
"## no critic" out RequireBriefOpen in tests.

13 years ago"## no critic" out ProhibitNoWarnings in tests.
Elliot Shank [Mon, 7 Jul 2008 01:04:01 +0000 (01:04 +0000)] 
"## no critic" out ProhibitNoWarnings in tests.

13 years agoFix RequireFinalReturn in tests.
Elliot Shank [Mon, 7 Jul 2008 01:00:26 +0000 (01:00 +0000)] 
Fix RequireFinalReturn in tests.

13 years agoFix RequireLocalizedPunctuationVars 07_perlcritic.t.
Elliot Shank [Mon, 7 Jul 2008 00:55:01 +0000 (00:55 +0000)] 
Fix RequireLocalizedPunctuationVars 07_perlcritic.t.

13 years ago"## no critic" ProhibitMultiplePackages in 02_policy.t.
Elliot Shank [Mon, 7 Jul 2008 00:50:52 +0000 (00:50 +0000)] 
"## no critic" ProhibitMultiplePackages in 02_policy.t.

13 years ago"## no critic" ProhibitStringyEval in 20_policies.t.
Elliot Shank [Mon, 7 Jul 2008 00:48:42 +0000 (00:48 +0000)] 
"## no critic" ProhibitStringyEval in 20_policies.t.

13 years ago"## no critic" RequireFilenameMatchesPackage in 02_policy.t.
Elliot Shank [Mon, 7 Jul 2008 00:46:23 +0000 (00:46 +0000)] 
"## no critic" RequireFilenameMatchesPackage in 02_policy.t.

13 years agoFix ProhibitMismatchedOperators in 94_includes.t.
Elliot Shank [Mon, 7 Jul 2008 00:43:12 +0000 (00:43 +0000)] 
Fix ProhibitMismatchedOperators in 94_includes.t.

13 years ago"## no critic" out ProhibitCStyleForLoops in tests.
Elliot Shank [Mon, 7 Jul 2008 00:37:03 +0000 (00:37 +0000)] 
"## no critic" out ProhibitCStyleForLoops in tests.

13 years agoFix missing trailing comma in 09_theme.t.
Elliot Shank [Mon, 7 Jul 2008 00:27:22 +0000 (00:27 +0000)] 
Fix missing trailing comma in 09_theme.t.

13 years agoFix hard tabs in 06_violation.t.
Elliot Shank [Mon, 7 Jul 2008 00:25:35 +0000 (00:25 +0000)] 
Fix hard tabs in 06_violation.t.

13 years agoFix RequireVersionVar in tests.
Elliot Shank [Mon, 7 Jul 2008 00:20:29 +0000 (00:20 +0000)] 
Fix RequireVersionVar in tests.

13 years agoTime for more self compliance: create 42_criticize-tests.t.
Elliot Shank [Sun, 6 Jul 2008 23:56:57 +0000 (23:56 +0000)] 
Time for more self compliance: create 42_criticize-tests.t.

13 years agoMove generate_without_optional_dependencies_wrappers.PL to
Elliot Shank [Sun, 6 Jul 2008 23:45:27 +0000 (23:45 +0000)] 
Move generate_without_optional_dependencies_wrappers.PL to
xt/author.

13 years agoFix evals in generated test wrappers and eliminate
Elliot Shank [Sun, 6 Jul 2008 23:29:20 +0000 (23:29 +0000)] 
Fix evals in generated test wrappers and eliminate
TestUtilitiesWithMinimalDependencies.

13 years agoMove the files related to 06_violation.t to
Elliot Shank [Sun, 6 Jul 2008 22:58:25 +0000 (22:58 +0000)] 
Move the files related to 06_violation.t to
t/06_violation.t.lib.

13 years agoFailing test for ProhibitSingleCharAlternation.
Elliot Shank [Sun, 6 Jul 2008 18:41:22 +0000 (18:41 +0000)] 
Failing test for ProhibitSingleCharAlternation.

13 years agoForgot to update Changes about ProhibitSleepViaSelect.
Elliot Shank [Fri, 4 Jul 2008 18:01:48 +0000 (18:01 +0000)] 
Forgot to update Changes about ProhibitSleepViaSelect.

13 years agoFix RT #37416, ProhibitSleepViaSelect, with three undef
Elliot Shank [Fri, 4 Jul 2008 17:54:57 +0000 (17:54 +0000)] 
Fix RT #37416, ProhibitSleepViaSelect, with three undef
arguments to select(), but one of them is the timeout.

13 years agoFix 1.088 date in Changes.
Elliot Shank [Fri, 4 Jul 2008 16:47:49 +0000 (16:47 +0000)] 
Fix 1.088 date in Changes.

13 years agoPOD cleanup in RequireCheckingReturnValueOfEval.
Elliot Shank [Fri, 4 Jul 2008 16:21:38 +0000 (16:21 +0000)] 
POD cleanup in RequireCheckingReturnValueOfEval.

13 years agoAnd there was a missing "1;" at the end of an eval in
Elliot Shank [Fri, 4 Jul 2008 16:21:04 +0000 (16:21 +0000)] 
And there was a missing "1;" at the end of an eval in
PodSpelling.

13 years agoForgot to add "1;" to end of eval block in RequireTidyCode.
Elliot Shank [Fri, 4 Jul 2008 15:33:13 +0000 (15:33 +0000)] 
Forgot to add "1;" to end of eval block in RequireTidyCode.

13 years agoBump P::C version to 1.088.
Elliot Shank [Thu, 3 Jul 2008 15:19:10 +0000 (15:19 +0000)] 
Bump P::C version to 1.088.

13 years agoDocument RequireCheckingReturnValueOfEval.
Elliot Shank [Thu, 3 Jul 2008 15:11:20 +0000 (15:11 +0000)] 
Document RequireCheckingReturnValueOfEval.

13 years agoAdd TODO about double periods in Violation.
Elliot Shank [Thu, 3 Jul 2008 14:36:05 +0000 (14:36 +0000)] 
Add TODO about double periods in Violation.

13 years agothe EXPL should not end with a period
Andy Lester [Thu, 3 Jul 2008 04:37:03 +0000 (04:37 +0000)] 
the EXPL should not end with a period

13 years agoFinish self compliance issues with
Elliot Shank [Wed, 2 Jul 2008 18:28:03 +0000 (18:28 +0000)] 
Finish self compliance issues with
RequireCheckingReturnValueOfEval.

This commit brought to you courtesy DRW Holdings who
provided me with an entertaining morning.  Development took
place before and in the interstices of this morning's
interview.  Thanks, guys!

13 years agoFinish implementation of RequireCheckingReturnValueOfEval.
Elliot Shank [Mon, 30 Jun 2008 05:37:19 +0000 (05:37 +0000)] 
Finish implementation of RequireCheckingReturnValueOfEval.
There's still documentation and some self-compliance issues
left.

13 years agoPrior to leaving for airport, commit what I've got so far on
Elliot Shank [Sun, 29 Jun 2008 18:47:22 +0000 (18:47 +0000)] 
Prior to leaving for airport, commit what I've got so far on
ErrorHandling::RequireCheckingReturnValueOfEval.

13 years agoProperly check result of eval in perlcritic. Should write the
Elliot Shank [Fri, 27 Jun 2008 14:38:59 +0000 (14:38 +0000)] 
Properly check result of eval in perlcritic.  Should write the
Policy before fixing more evals, just to test the Policy.

13 years agoAfter discussion at YAPC, raise ProhibitUnusedVariables
Elliot Shank [Wed, 25 Jun 2008 14:21:28 +0000 (14:21 +0000)] 
After discussion at YAPC, raise ProhibitUnusedVariables
default severity to medium.

13 years agoLink to Ovid's use.perl Journal entry in the
Elliot Shank [Tue, 24 Jun 2008 18:07:31 +0000 (18:07 +0000)] 
Link to Ovid's use.perl Journal entry in the
ErrorHandling::RequireLocalizingEvalErrorInDESTROY section
in TODO.pod.

13 years agoSuggest ErrorHandling::RequireLocalizingEvalErrorInDESTROY
Elliot Shank [Tue, 24 Jun 2008 18:04:46 +0000 (18:04 +0000)] 
Suggest ErrorHandling::RequireLocalizingEvalErrorInDESTROY
Policy in TODO.pod.

13 years agoModify suggestion for Policy name that prohibits calling
Elliot Shank [Tue, 24 Jun 2008 05:08:31 +0000 (05:08 +0000)] 
Modify suggestion for Policy name that prohibits calling
exit.

13 years agoAdded a TODO for ProhibitExit
Chris Dolan [Tue, 24 Jun 2008 04:53:39 +0000 (04:53 +0000)] 
Added a TODO for ProhibitExit

13 years agoFix ProhibitInterpolationOfLiterals in
Elliot Shank [Sun, 22 Jun 2008 23:38:04 +0000 (23:38 +0000)] 
Fix ProhibitInterpolationOfLiterals in
ValuesAndExpressions::ProhibitLeadingZeros.  RT #31977 now
whacked.

13 years agoChange ValuesAndExpressions::ProhibitLeadingZeros to allow
Elliot Shank [Sun, 22 Jun 2008 23:23:43 +0000 (23:23 +0000)] 
Change ValuesAndExpressions::ProhibitLeadingZeros to allow
octal in the fourth argument to sysopen by default.

13 years agoChange ValuesAndExpressions::ProhibitLeadingZeros to allow
Elliot Shank [Sun, 22 Jun 2008 23:04:46 +0000 (23:04 +0000)] 
Change ValuesAndExpressions::ProhibitLeadingZeros to allow
octal in the third argument to dbmopen by default.

13 years agoChange ValuesAndExpressions::ProhibitLeadingZeros to allow
Elliot Shank [Sun, 22 Jun 2008 22:49:00 +0000 (22:49 +0000)] 
Change ValuesAndExpressions::ProhibitLeadingZeros to allow
octal in the first argument to umask by default.

13 years agoChange ValuesAndExpressions::ProhibitLeadingZeros to allow
Elliot Shank [Sun, 22 Jun 2008 22:43:37 +0000 (22:43 +0000)] 
Change ValuesAndExpressions::ProhibitLeadingZeros to allow
octal in the second argument to mkdir by default.

13 years agoChange ValuesAndExpressions::ProhibitLeadingZeros to allow
Elliot Shank [Sun, 22 Jun 2008 22:20:58 +0000 (22:20 +0000)] 
Change ValuesAndExpressions::ProhibitLeadingZeros to allow
octal in the first argument by default.

13 years agoAdd RegularExpressions::RequreDotMatchAnything Policy to
Elliot Shank [Sun, 22 Jun 2008 21:31:47 +0000 (21:31 +0000)] 
Add RegularExpressions::RequreDotMatchAnything Policy to
TODO.pod.

13 years agoChange ProhibitLeadingZeros to apply to Token::Number::Octal
Elliot Shank [Sun, 22 Jun 2008 21:25:52 +0000 (21:25 +0000)] 
Change ProhibitLeadingZeros to apply to Token::Number::Octal
instead of merely Token::Number.

13 years agoChange the --Version option to --version.
Elliot Shank [Sun, 22 Jun 2008 21:00:39 +0000 (21:00 +0000)] 
Change the --Version option to --version.

13 years agoAdd periods to the end of abstracts for ppidump, perlcritic,
Elliot Shank [Sun, 22 Jun 2008 18:08:37 +0000 (18:08 +0000)] 
Add periods to the end of abstracts for ppidump, perlcritic,
and KomodoIntegration.pod.

13 years agoBump P::C version to 1.087. v1.087
Elliot Shank [Sun, 22 Jun 2008 03:17:44 +0000 (03:17 +0000)] 
Bump P::C version to 1.087.

13 years agoMoved detection of the lack of any enabled policies from
Elliot Shank [Sun, 22 Jun 2008 02:57:54 +0000 (02:57 +0000)] 
Moved detection of the lack of any enabled policies from
Config to Perl::Critic itself.

13 years agoHandle files with name "0".
Elliot Shank [Sat, 21 Jun 2008 17:29:53 +0000 (17:29 +0000)] 
Handle files with name "0".

13 years agoProhibitTwoArgOpen now ignores files with "use 5.005".
Elliot Shank [Thu, 19 Jun 2008 20:03:01 +0000 (20:03 +0000)] 
ProhibitTwoArgOpen now ignores files with "use 5.005".
ADAMK can now be more happy.

13 years agoFix Complexity in ProhibitParensWithBuiltins.
Elliot Shank [Wed, 18 Jun 2008 21:46:10 +0000 (21:46 +0000)] 
Fix Complexity in ProhibitParensWithBuiltins.

13 years agoRequireUseWarnings now ignores files with "use 5.005".
Elliot Shank [Wed, 18 Jun 2008 21:19:46 +0000 (21:19 +0000)] 
RequireUseWarnings now ignores files with "use 5.005".
ADAMK can now be happy.

13 years agoEnsure all Makefile.PL and Build.PL files include a
Elliot Shank [Tue, 17 Jun 2008 19:27:21 +0000 (19:27 +0000)] 
Ensure all Makefile.PL and Build.PL files include a
"use 5.006001" statement.  Dang those 5.5.5 CPAN
Testers.  :]

13 years agoMore spaces in RequireTidyCode.
Elliot Shank [Tue, 17 Jun 2008 18:32:39 +0000 (18:32 +0000)] 
More spaces in RequireTidyCode.

13 years agoChange qr delimiters and insert some spaces to make regexes
Elliot Shank [Tue, 17 Jun 2008 18:28:56 +0000 (18:28 +0000)] 
Change qr delimiters and insert some spaces to make regexes
easier to read in RequireTidyCode.

13 years agoUpdate P::C Changes to reflect Chris'
Elliot Shank [Tue, 17 Jun 2008 15:22:23 +0000 (15:22 +0000)] 
Update P::C Changes to reflect Chris'
ProhibitParensWithBuiltins fix.

13 years agoSpecial case allow for sort(foo(@x)) in ProhibitParensWithBuiltins
Chris Dolan [Tue, 17 Jun 2008 06:11:23 +0000 (06:11 +0000)] 
Special case allow for sort(foo(@x)) in ProhibitParensWithBuiltins

13 years agoFailing test for CodeLayout::ProhibitParensWithBuiltins
Elliot Shank [Sun, 15 Jun 2008 19:59:05 +0000 (19:59 +0000)] 
Failing test for CodeLayout::ProhibitParensWithBuiltins
dealing with the first argument to sort.

13 years agoBump P::C version to 1.086. v1.086
Elliot Shank [Thu, 12 Jun 2008 18:17:36 +0000 (18:17 +0000)] 
Bump P::C version to 1.086.

13 years agoChange indent in Changes to 4 spaces instead of 5. Grrr,
Elliot Shank [Wed, 11 Jun 2008 20:21:49 +0000 (20:21 +0000)] 
Change indent in Changes to 4 spaces instead of 5.  Grrr,
that was driving me nuts every time I had to back space and
re-tab over.

13 years agoChange NamingConventions::ProhibitAmbiguousNames to specify
Elliot Shank [Wed, 11 Jun 2008 20:19:00 +0000 (20:19 +0000)] 
Change NamingConventions::ProhibitAmbiguousNames to specify
the name that it had a problem with.

13 years agoWow. Term::ANSIColor wasn't in the recommended module list.
Elliot Shank [Mon, 9 Jun 2008 03:20:26 +0000 (03:20 +0000)] 
Wow.  Term::ANSIColor wasn't in the recommended module list.

13 years agoMake --colour equivalent to --color.
Elliot Shank [Mon, 9 Jun 2008 01:41:30 +0000 (01:41 +0000)] 
Make --colour equivalent to --color.

13 years agoFix RT #36569. The color option wasn't being paid attention
Elliot Shank [Mon, 9 Jun 2008 01:19:45 +0000 (01:19 +0000)] 
Fix RT #36569.  The color option wasn't being paid attention
to in a .perlcriticrc.

13 years agoBump P::C version to 1.085. v1.085
Elliot Shank [Sun, 8 Jun 2008 03:14:21 +0000 (03:14 +0000)] 
Bump P::C version to 1.085.

13 years agoUpdate Changes.
Elliot Shank [Sun, 8 Jun 2008 02:47:39 +0000 (02:47 +0000)] 
Update Changes.

13 years agoCatch a few more cases in ProhibitUnusedVariables.
Elliot Shank [Sun, 8 Jun 2008 02:31:50 +0000 (02:31 +0000)] 
Catch a few more cases in ProhibitUnusedVariables.

13 years agoWhoops. Just because Readonly loads, don't assume that
Elliot Shank [Sun, 8 Jun 2008 02:03:30 +0000 (02:03 +0000)] 
Whoops.  Just because Readonly loads, don't assume that
Readonly::XS has.

13 years agoFix BuildUtilities handling of Readonly::XS. Readonly::XS
Elliot Shank [Sun, 8 Jun 2008 01:53:51 +0000 (01:53 +0000)] 
Fix BuildUtilities handling of Readonly::XS.  Readonly::XS
refuses to load if Readonly isn't already loaded.

13 years agoRemove failing test for
Elliot Shank [Sat, 7 Jun 2008 00:57:46 +0000 (00:57 +0000)] 
Remove failing test for
RegularExpressions::ProhibitSingleCharAlternation from ack,
since the case was actually covered in the original tests,
with the "vote" going for it failing.

Change the violation description to be specific about what
the change should be.

13 years agoGet explicit about the perl dependency and put a
Elliot Shank [Fri, 6 Jun 2008 05:48:04 +0000 (05:48 +0000)] 
Get explicit about the perl dependency and put a
"use 5.006001" everywhere.

13 years agoMisplaced returns in t/14_policy_parameters.t.
Elliot Shank [Fri, 6 Jun 2008 05:32:06 +0000 (05:32 +0000)] 
Misplaced returns in t/14_policy_parameters.t.

13 years agoImplemented Documentation::RequirePackageMatchesPodName
Chris Dolan [Fri, 6 Jun 2008 03:24:36 +0000 (03:24 +0000)] 
Implemented Documentation::RequirePackageMatchesPodName

13 years agoAdd a bit of explanation to ProhibitPostfixControls.
Elliot Shank [Thu, 5 Jun 2008 21:12:35 +0000 (21:12 +0000)] 
Add a bit of explanation to ProhibitPostfixControls.

13 years agoAdd missing dependency upon Exporter to Makefile.PL and
Elliot Shank [Thu, 5 Jun 2008 20:50:17 +0000 (20:50 +0000)] 
Add missing dependency upon Exporter to Makefile.PL and
Build.PL.  Add Readonly::XS to recommended modules.

13 years agoAdd two documentation policies to TODO.
Elliot Shank [Thu, 5 Jun 2008 19:47:02 +0000 (19:47 +0000)] 
Add two documentation policies to TODO.

13 years ago until is also a control conditional
Ricardo Signes [Wed, 4 Jun 2008 01:06:33 +0000 (01:06 +0000)] 
 until is also a control conditional

13 years agoOh, the horror of an extra semi-colon in one's code! Found
Elliot Shank [Tue, 3 Jun 2008 06:30:33 +0000 (06:30 +0000)] 
Oh, the horror of an extra semi-colon in one's code!  Found
by Kevin Ryde's ProhibitNullStatements policy.

13 years agoFailing test from ack for
Elliot Shank [Sun, 25 May 2008 03:45:16 +0000 (03:45 +0000)] 
Failing test from ack for
RegularExpressions::ProhibitSingleCharAlternation.