Login
gknop/Perl-Critic.git
14 years agoFix a few miscellaneous self violations
Chris Dolan [Wed, 3 Oct 2007 05:47:53 +0000 (05:47 +0000)] 
Fix a few miscellaneous self violations
Add a TODO test for mixed booleans inside "eval { ... }"

14 years agoFurther work on RequireLocalizedPunctuationVars.run.PL
Chris Dolan [Wed, 3 Oct 2007 05:33:11 +0000 (05:33 +0000)] 
Further work on RequireLocalizedPunctuationVars.run.PL

14 years agoReworking RequireLocalizedPunctuationVars tests in light of PPI
Chris Dolan [Wed, 3 Oct 2007 05:27:14 +0000 (05:27 +0000)] 
Reworking RequireLocalizedPunctuationVars tests in light of PPI
bugfixes and Elliot's .PL pattern

14 years agoHook ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL
Elliot Shank [Tue, 2 Oct 2007 15:31:31 +0000 (15:31 +0000)] 
Hook ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.PL
into Build.PL and Makefile.PL.

14 years agoGenerate
Elliot Shank [Tue, 2 Oct 2007 14:37:41 +0000 (14:37 +0000)] 
Generate
t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run.

14 years agoDegrade (sort-of) gracefully is aspell is installed but aspell-en is not
Chris Dolan [Tue, 2 Oct 2007 00:43:10 +0000 (00:43 +0000)] 
Degrade (sort-of) gracefully is aspell is installed but aspell-en is not
Workaround for File::Which warning in TEST_AUTHOR mode

14 years agoMention name of unchecked function in violation description for
Chris Dolan [Sun, 30 Sep 2007 20:22:27 +0000 (20:22 +0000)] 
Mention name of unchecked function in violation description for
InputOutput::RequireCheckedSyscalls

14 years agoPer request from David Golden, allow "local" to be used in conditional statements.
Jeffrey Ryan Thalhammer [Fri, 28 Sep 2007 15:42:13 +0000 (15:42 +0000)] 
Per request from David Golden, allow "local" to be used in conditional statements.

14 years agoCode coverage
Chris Dolan [Thu, 27 Sep 2007 05:33:14 +0000 (05:33 +0000)] 
Code coverage
Discourage "$foo =~ $regexp" and encourage "$foo =~ m/$regexp/" instead

14 years agoNew policy InputOutput::RequireCheckedSyscalls
Chris Dolan [Wed, 26 Sep 2007 05:38:12 +0000 (05:38 +0000)] 
New policy InputOutput::RequireCheckedSyscalls
Less a few tweaks and rearranging, this completes my TPF grant!
We may want to adjust t/40_perlcriticrc for this new policy (to
  include more builtins to flag)

14 years agoUpdate todo.
Elliot Shank [Wed, 26 Sep 2007 05:20:07 +0000 (05:20 +0000)] 
Update todo.

14 years agoAdd todo for #line directives.
Elliot Shank [Wed, 26 Sep 2007 05:09:24 +0000 (05:09 +0000)] 
Add todo for #line directives.

14 years agoAdd exceptions for Fatal and Fatal::Exception to InputOutput::RequireCheckedOpen...
Chris Dolan [Wed, 26 Sep 2007 04:17:23 +0000 (04:17 +0000)] 
Add exceptions for Fatal and Fatal::Exception to InputOutput::RequireCheckedOpen/Close
Add smarts about qw() to parse_arg_list

14 years agoDoc error: the config parameter stop_words was misspelled
Chris Dolan [Mon, 24 Sep 2007 04:32:25 +0000 (04:32 +0000)] 
Doc error: the config parameter stop_words was misspelled

14 years agoMinor test renaming.
Elliot Shank [Mon, 24 Sep 2007 04:13:52 +0000 (04:13 +0000)] 
Minor test renaming.

14 years agoCode coverage improvements; minor code tweaks
Chris Dolan [Mon, 24 Sep 2007 02:22:44 +0000 (02:22 +0000)] 
Code coverage improvements; minor code tweaks

14 years agoNew policy InputOutput::RequireBriefOpen
Chris Dolan [Sun, 23 Sep 2007 02:25:07 +0000 (02:25 +0000)] 
New policy InputOutput::RequireBriefOpen

14 years agoRefactor to reduce complexity of violates() method in ProhibitEnumeratedClasses.pm
Chris Dolan [Sun, 23 Sep 2007 01:46:14 +0000 (01:46 +0000)] 
Refactor to reduce complexity of violates() method in ProhibitEnumeratedClasses.pm

14 years agoAdd optimizations to the regexp policies to do culling tests before
Chris Dolan [Sun, 23 Sep 2007 00:55:46 +0000 (00:55 +0000)] 
Add optimizations to the regexp policies to do culling tests before
invoking the regexp parser.

14 years agoNew policy RegularExpressions::ProhibitEnumeratedClasses
Chris Dolan [Sat, 22 Sep 2007 05:50:28 +0000 (05:50 +0000)] 
New policy RegularExpressions::ProhibitEnumeratedClasses

14 years agoTweak to ProhibitComplexRegexes so \p{IsUppercase} and the like don't
Chris Dolan [Sat, 22 Sep 2007 05:44:04 +0000 (05:44 +0000)] 
Tweak to ProhibitComplexRegexes so \p{IsUppercase} and the like don't
count against us so much.  Maybe we should count tokens instead of
characters.  Hmm...

14 years agoNew policy RegularExpressions::ProhibitEscapedMetacharacters
Chris Dolan [Fri, 21 Sep 2007 06:52:26 +0000 (06:52 +0000)] 
New policy RegularExpressions::ProhibitEscapedMetacharacters
Several changes to achieve compliance

14 years agoAdd overlooked flag for optional module
Chris Dolan [Fri, 21 Sep 2007 04:25:19 +0000 (04:25 +0000)] 
Add overlooked flag for optional module

14 years agoAdd tests to confirm that the severities are right in PolicySummary.pod
Chris Dolan [Fri, 21 Sep 2007 04:17:42 +0000 (04:17 +0000)] 
Add tests to confirm that the severities are right in PolicySummary.pod

14 years agoAdd TODO for new idea: RegularExpressions::ProhibitUnnecessaryEscapes
Chris Dolan [Fri, 21 Sep 2007 03:36:19 +0000 (03:36 +0000)] 
Add TODO for new idea: RegularExpressions::ProhibitUnnecessaryEscapes

14 years agoAdd ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
Elliot Shank [Thu, 20 Sep 2007 14:28:05 +0000 (14:28 +0000)] 
Add ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
policy.

Needs spelling fix and more tests.

14 years agoFix Pod::Spelling problem.
Elliot Shank [Thu, 20 Sep 2007 13:25:32 +0000 (13:25 +0000)] 
Fix Pod::Spelling problem.

14 years agoMerge P::C 1.078 to the 1.xxx branch.
Elliot Shank [Thu, 20 Sep 2007 13:21:57 +0000 (13:21 +0000)] 
Merge P::C 1.078 to the 1.xxx branch.

14 years agoNew policy RegularExpressions::ProhibitSingleCharAlternation
Chris Dolan [Thu, 20 Sep 2007 06:50:51 +0000 (06:50 +0000)] 
New policy RegularExpressions::ProhibitSingleCharAlternation

To accomplish this, I wrote a simple PPI wrapper around the
Regexp::Parser DOM.  The code is a little unpleasant, but I hope that
this will be internalized to PPI someday and we can delete my work.

14 years agoMerge some changes from my personal version of includes.t into the P::C version
Chris Dolan [Thu, 20 Sep 2007 06:41:43 +0000 (06:41 +0000)] 
Merge some changes from my personal version of includes.t into the P::C version

14 years agoperlcritic wasn't letting you use the %P placeholder in the verbose format specification.
Jeffrey Ryan Thalhammer [Thu, 20 Sep 2007 06:20:55 +0000 (06:20 +0000)] 
perlcritic wasn't letting you use the %P placeholder in the verbose format specification.

I should probably factor out the list of placeholders into a package var to avoid duplication.

-lThis line, and those below, will be ignored--

M    perlcritic

14 years agoFixed typo in documentation, reported as...
Jeffrey Ryan Thalhammer [Thu, 20 Sep 2007 05:40:22 +0000 (05:40 +0000)] 
Fixed typo in documentation, reported as...
http://rt.cpan.org/Ticket/Display.html?id=28646

14 years agoAdd policy that enforces checking of $EVAL_ERROR after
Elliot Shank [Tue, 18 Sep 2007 18:03:08 +0000 (18:03 +0000)] 
Add policy that enforces checking of $EVAL_ERROR after
an eval to TODO.pod.

14 years agoFix cases where I got the expanation and description of a violation
Elliot Shank [Mon, 17 Sep 2007 02:31:50 +0000 (02:31 +0000)] 
Fix cases where I got the expanation and description of a violation
reversed.

14 years agoReplace references to new() with initialize_if_enabled() in
Elliot Shank [Mon, 17 Sep 2007 02:07:48 +0000 (02:07 +0000)] 
Replace references to new() with initialize_if_enabled() in
DEVELOPER.pod.

14 years agoOops, forgot to indicate RC argument key for ProhibitComplexRegexes
Chris Dolan [Sun, 16 Sep 2007 23:48:26 +0000 (23:48 +0000)] 
Oops, forgot to indicate RC argument key for ProhibitComplexRegexes

14 years agoFalse positive for s/(foo)/$1/ in
Chris Dolan [Sun, 16 Sep 2007 23:41:58 +0000 (23:41 +0000)] 
False positive for s/(foo)/$1/ in
RegularExpressions::ProhibitUnusedCapture.  I wasn't looking at the
replace string.

Note: the implementation of the fix for this is bit quick-and-dirty.
At some point, we may wish to use a parser for interpolated strings.
Maybe that should be built into PPI, since it already has to do that
parse once.

14 years agoChange default trigger from 50 chars to 60 chars in
Chris Dolan [Sun, 16 Sep 2007 23:39:31 +0000 (23:39 +0000)] 
Change default trigger from 50 chars to 60 chars in
RegularExpressions::ProhibitComplexRegexes after trying this policy
out on some real world code.  50 was too low.

14 years agoMerge r1904-r1908, the 1.077 release, to the 1.xxx branch.
Elliot Shank [Sat, 15 Sep 2007 14:59:45 +0000 (14:59 +0000)] 
Merge r1904-r1908, the 1.077 release, to the 1.xxx branch.

14 years agoNew policy RegularExpressions::ProhibitComplexRegexes
Chris Dolan [Thu, 13 Sep 2007 06:13:31 +0000 (06:13 +0000)] 
New policy RegularExpressions::ProhibitComplexRegexes

14 years agoThree changes to Critic.pm, in order of significance
Chris Dolan [Thu, 13 Sep 2007 02:10:10 +0000 (02:10 +0000)] 
Three changes to Critic.pm, in order of significance

  * Allow ##no critic after the shebang, which can block policies that
    apply to whole documents.  See email thread titled "How to turn
    off Modules::ProhibitExcessMainComplexity per file ?" on
    users@perlcritic.tigris.org.

  * Don't auto-vivify undefs in the %is_line_disabled hash

  * Small performance boost to pass invariant array of policies by
    reference -- savings of up to (N policies) x (M "##no critic"
    lines) variable touches

14 years agoMerge r1895, add Readonly to the Build requirements, to the
Elliot Shank [Wed, 12 Sep 2007 16:21:42 +0000 (16:21 +0000)] 
Merge r1895, add Readonly to the Build requirements, to the
1.xxx branch.

14 years agoMerge r1890 & r1891, the 1.076 release, to the 1.xxx branch.
Elliot Shank [Wed, 12 Sep 2007 16:18:17 +0000 (16:18 +0000)] 
Merge r1890 & r1891, the 1.076 release, to the 1.xxx branch.

14 years agoMerge r1882-r1884 & r1886, the 1.075_001, to the 1.xxx branch.
Elliot Shank [Wed, 12 Sep 2007 16:03:54 +0000 (16:03 +0000)] 
Merge r1882-r1884 & r1886, the 1.075_001, to the 1.xxx branch.

14 years agoMerge r1877 & 1878, the 1.074 release, to the 1.xxx branch.
Elliot Shank [Wed, 12 Sep 2007 15:52:02 +0000 (15:52 +0000)] 
Merge r1877 & 1878, the 1.074 release, to the 1.xxx branch.

14 years agoNew policy RegularExpressions::ProhibitUnusedCapture
Chris Dolan [Tue, 11 Sep 2007 09:08:22 +0000 (09:08 +0000)] 
New policy RegularExpressions::ProhibitUnusedCapture

This one was really hard to write and probably has a lot of false
positives.  Please try it on real-world code and send in problems (or
better yet test cases!)

14 years agoAdded a new optional_modules parameter to the .run syntax. This turns
Chris Dolan [Tue, 11 Sep 2007 09:00:39 +0000 (09:00 +0000)] 
Added a new optional_modules parameter to the .run syntax.  This turns
off any failures if any of the optional modules are missing.

14 years agoAdd comments to the TODO about the feasibility of implementing the remaining regexp...
Chris Dolan [Sun, 9 Sep 2007 02:22:07 +0000 (02:22 +0000)] 
Add comments to the TODO about the feasibility of implementing the remaining regexp policies.

14 years agoNew Policies
Chris Dolan [Sat, 8 Sep 2007 04:20:14 +0000 (04:20 +0000)] 
New Policies
  RegularExpressions::ProhibitUnusualDelimiters
  RegularExpressions::RequireBracesForMultiline

14 years agoFix typos and add to TODO.
Elliot Shank [Fri, 7 Sep 2007 01:52:28 +0000 (01:52 +0000)] 
Fix typos and add to TODO.

14 years agoAdd todo.
Elliot Shank [Wed, 5 Sep 2007 21:50:09 +0000 (21:50 +0000)] 
Add todo.

14 years agoMerge r1873 & 1874, the 1.073 release, to the 1.xxx branch.
Elliot Shank [Tue, 4 Sep 2007 06:21:36 +0000 (06:21 +0000)] 
Merge r1873 & 1874, the 1.073 release, to the 1.xxx branch.

14 years agoRemove completed policy from TODO
Chris Dolan [Tue, 4 Sep 2007 04:24:08 +0000 (04:24 +0000)] 
Remove completed policy from TODO

14 years agoNew policies:
Chris Dolan [Tue, 4 Sep 2007 04:22:29 +0000 (04:22 +0000)] 
New policies:
  InputOutput::ProhibitExplicitStdin
  RegularExpressions::ProhibitFixedStringMatches

14 years agoUpdate release date of P::C 1.072 in Changes. v1.072
Elliot Shank [Mon, 3 Sep 2007 22:59:58 +0000 (22:59 +0000)] 
Update release date of P::C 1.072 in Changes.

14 years agoAdd attribution to the Makefile.PL fixes in Changes.
Elliot Shank [Mon, 3 Sep 2007 20:07:13 +0000 (20:07 +0000)] 
Add attribution to the Makefile.PL fixes in Changes.

14 years agoFix date of P::C 1.071 release in Changes.
Elliot Shank [Mon, 3 Sep 2007 02:32:23 +0000 (02:32 +0000)] 
Fix date of P::C 1.071 release in Changes.

14 years agoBump P::C version to 1.072.
Elliot Shank [Mon, 3 Sep 2007 01:13:48 +0000 (01:13 +0000)] 
Bump P::C version to 1.072.

14 years agoReplace hand-coded module-hiding wrappers for tests with generated
Elliot Shank [Mon, 3 Sep 2007 01:07:03 +0000 (01:07 +0000)] 
Replace hand-coded module-hiding wrappers for tests with generated
ones.

14 years agoRemove backslash from end of last line in the tags target
Elliot Shank [Fri, 24 Aug 2007 16:23:28 +0000 (16:23 +0000)] 
Remove backslash from end of last line in the tags target
in Makefile.PL.

14 years agoUse \t instead of actual whitespace in the tags target in
Elliot Shank [Fri, 24 Aug 2007 16:19:30 +0000 (16:19 +0000)] 
Use \t instead of actual whitespace in the tags target in
Makefile.PL.

14 years agoBump version to 1.071 and update Changes to reflect bug fixes. v1.071
Elliot Shank [Fri, 24 Aug 2007 15:57:01 +0000 (15:57 +0000)] 
Bump version to 1.071 and update Changes to reflect bug fixes.

14 years agoThis should fix all the failures with 1.07, with tests to ensure
Elliot Shank [Fri, 24 Aug 2007 05:54:32 +0000 (05:54 +0000)] 
This should fix all the failures with 1.07, with tests to ensure
it doesn't happen again.

14 years agoUpdate some POD in Perl::Critic and perlcritic, set the date v1.07
Elliot Shank [Tue, 21 Aug 2007 13:58:24 +0000 (13:58 +0000)] 
Update some POD in Perl::Critic and perlcritic, set the date
in Changes, and regenerate README and META.yml in preparation
for the 1.07 release.

14 years agoBump version number to 1.07.
Elliot Shank [Sun, 19 Aug 2007 17:37:41 +0000 (17:37 +0000)] 
Bump version number to 1.07.

14 years agoAdd descriptions to the NAME POD section in P::C::Utils::*.
Elliot Shank [Sun, 19 Aug 2007 16:22:59 +0000 (16:22 +0000)] 
Add descriptions to the NAME POD section in P::C::Utils::*.

14 years agoReplace --strict-profile option with --profile-strictness one.
Elliot Shank [Mon, 13 Aug 2007 06:21:51 +0000 (06:21 +0000)] 
Replace --strict-profile option with --profile-strictness one.

Put comment at top of P::C::Utils requesting that new functionality
be placed in P::C::Utils::* because P::C::Utils is way too big and
complicated.

14 years agoNew policy InputOutput::ProhibitJoinedReadline
Chris Dolan [Thu, 9 Aug 2007 05:25:39 +0000 (05:25 +0000)] 
New policy InputOutput::ProhibitJoinedReadline

14 years agoAdd add_themes parameters to profile prototype.
Elliot Shank [Tue, 7 Aug 2007 02:47:58 +0000 (02:47 +0000)] 
Add add_themes parameters to profile prototype.
Fix overzealous RequireArgUnpacking conformance.  :]

14 years agoNew policy Subroutines::ProhibitManyArgs
Chris Dolan [Sun, 5 Aug 2007 02:38:16 +0000 (02:38 +0000)] 
New policy Subroutines::ProhibitManyArgs

14 years agoPut the severity of Subroutines::ProhibitNestedSubs to 5,
Elliot Shank [Tue, 31 Jul 2007 12:08:58 +0000 (12:08 +0000)] 
Put the severity of Subroutines::ProhibitNestedSubs to 5,
where RJBS originally had it.

14 years agoAdd RJBS' ProhibitNestedSubs policy.
Elliot Shank [Tue, 31 Jul 2007 02:55:35 +0000 (02:55 +0000)] 
Add RJBS' ProhibitNestedSubs policy.

14 years agoUpdate Changes to include a mention of initialize_if_enabled().
Elliot Shank [Fri, 27 Jul 2007 15:19:09 +0000 (15:19 +0000)] 
Update Changes to include a mention of initialize_if_enabled().

14 years agoBring the 1.061 version number bump to the Perl-Critic-1.xxx branch.
Elliot Shank [Wed, 25 Jul 2007 15:34:04 +0000 (15:34 +0000)] 
Bring the 1.061 version number bump to the Perl-Critic-1.xxx branch.

14 years agoSwitch remaining Policies from using constructors to use
Elliot Shank [Wed, 25 Jul 2007 01:36:45 +0000 (01:36 +0000)] 
Switch remaining Policies from using constructors to use
initialize_if_enabled.

14 years agoReorder methods in Documentation::PodSpelling to make violates()
Elliot Shank [Tue, 24 Jul 2007 18:58:11 +0000 (18:58 +0000)] 
Reorder methods in Documentation::PodSpelling to make violates()
more prominent.  Accessor-fy ProhibitHardTabs.

14 years agoAdd P::C::Policy::initialize_if_enabled() which, rather than new(),
Elliot Shank [Mon, 23 Jul 2007 14:42:15 +0000 (14:42 +0000)] 
Add P::C::Policy::initialize_if_enabled() which, rather than new(),
only gets called if the user has enabled the Policy.  Also,
initialize_if_enabled() returns whether the Policy should be disabled
even if the user says it should be enabled.

14 years agoCreate tests for P::C::Utils::PPI.
Elliot Shank [Mon, 23 Jul 2007 14:33:25 +0000 (14:33 +0000)] 
Create tests for P::C::Utils::PPI.

14 years agoSelf compliance with RequireArgUnpacking
Chris Dolan [Sun, 22 Jul 2007 02:45:22 +0000 (02:45 +0000)] 
Self compliance with RequireArgUnpacking

14 years agoSimplify a complex subroutine
Chris Dolan [Sun, 22 Jul 2007 02:44:21 +0000 (02:44 +0000)] 
Simplify a complex subroutine

14 years agoRewrite Subroutines::RequireArgUnpacking
Chris Dolan [Sun, 22 Jul 2007 02:30:56 +0000 (02:30 +0000)] 
Rewrite Subroutines::RequireArgUnpacking

14 years agoFirst draft of Subroutines::RequireArgUnpacking, but it causes too
Chris Dolan [Sat, 21 Jul 2007 19:13:43 +0000 (19:13 +0000)] 
First draft of Subroutines::RequireArgUnpacking, but it causes too
many false positives, so I'm going to rewrite it.  Committing just so
I have this draft for ideas for later.

14 years agoSkip unit tests if Pod::Spell is installed but aspell is not
Chris Dolan [Sat, 21 Jul 2007 04:21:10 +0000 (04:21 +0000)] 
Skip unit tests if Pod::Spell is installed but aspell is not

14 years agoNew policy Documentation::PodSpelling
Chris Dolan [Fri, 20 Jul 2007 07:08:48 +0000 (07:08 +0000)] 
New policy Documentation::PodSpelling
  This is very much inspired by Test::Spelling, but does not use that module
  Negative:
   * added 5 dependencies to Build.PL
   * relies on external spelling program, like Test::Spelling
  Positives:
   * tries to handle infrastructure failures gracefully
   * this obsoletes t/97_spelling.t

14 years agoforgot to commit a PolicySummary.pod change
Chris Dolan [Fri, 20 Jul 2007 01:58:28 +0000 (01:58 +0000)] 
forgot to commit a PolicySummary.pod change

14 years agoSelf-compliance with RequireLocalizedPunctuationVars and a bug fix in
Chris Dolan [Thu, 19 Jul 2007 05:04:59 +0000 (05:04 +0000)] 
Self-compliance with RequireLocalizedPunctuationVars and a bug fix in
that policy

14 years agoNew policy Variables::RequireLocalizedPunctuationVars
Chris Dolan [Thu, 19 Jul 2007 04:53:18 +0000 (04:53 +0000)] 
New policy Variables::RequireLocalizedPunctuationVars
  This was harder than I expected and still has some TODOs
Note that the .run file is autogenerated by pulling variable names
  from B::Keywords at author time.
PENDING: P::C is not yet self-compliant with this policy

14 years agoSeparate out 5.6 compatibility fixes in Changes in
Elliot Shank [Thu, 12 Jul 2007 01:33:13 +0000 (01:33 +0000)] 
Separate out 5.6 compatibility fixes in Changes in
the Perl-Critic-1.xxx branch due to separate release.

14 years agoTurn an attribute of RequireFinalReturn into a constant.
Elliot Shank [Wed, 11 Jul 2007 21:03:06 +0000 (21:03 +0000)] 
Turn an attribute of RequireFinalReturn into a constant.
Clean up trailing whitespace in ProhibitImplicitNewlines.

14 years agoFix t/97_spelling.t failures by making capitalization of "HEREDOCs"
Elliot Shank [Wed, 11 Jul 2007 20:45:55 +0000 (20:45 +0000)] 
Fix t/97_spelling.t failures by making capitalization of "HEREDOCs"
consistent.

14 years agoDeal with eval of an empty string not resetting $@/$EVAL_ERROR
Elliot Shank [Wed, 11 Jul 2007 20:37:42 +0000 (20:37 +0000)] 
Deal with eval of an empty string not resetting $@/$EVAL_ERROR
in Perl 5.6.

14 years agoNew policy ValuesAndExpressions::ProhibitImplicitNewlines
Chris Dolan [Wed, 11 Jul 2007 05:27:55 +0000 (05:27 +0000)] 
New policy ValuesAndExpressions::ProhibitImplicitNewlines

14 years agoNew policy BuiltinFunctions::ProhibitBooleanGrep
Chris Dolan [Wed, 11 Jul 2007 04:55:53 +0000 (04:55 +0000)] 
New policy BuiltinFunctions::ProhibitBooleanGrep
Make a TODO test in BuiltinFunctions::ProhibitVoidGrep for void caused by comma-statements
Tweak 20_policies.t to allow argument to be a path to a .run file
  (useful for development)
Trivial typo in Subroutines::RequireFinalReturn

14 years agoConvert BuiltinFunctions::ProhibitComplexMappings to use Readonly.
Elliot Shank [Sun, 8 Jul 2007 08:22:59 +0000 (08:22 +0000)] 
Convert BuiltinFunctions::ProhibitComplexMappings to use Readonly.

14 years agoFix Readonly usage in P::C::U::McCabe in Perl-Critic-1.xxx
Elliot Shank [Sun, 8 Jul 2007 08:05:40 +0000 (08:05 +0000)] 
Fix Readonly usage in P::C::U::McCabe in Perl-Critic-1.xxx
branch.

14 years agoMerge magic number cleanups, r1596 & r1597, to Perl-Critic-1.xxx
Elliot Shank [Sun, 8 Jul 2007 07:49:35 +0000 (07:49 +0000)] 
Merge magic number cleanups, r1596 & r1597, to Perl-Critic-1.xxx
branch.

14 years agoMerge the Readonly changes from trunk to the Perl-Critic-1.xxx
Elliot Shank [Sun, 8 Jul 2007 07:34:47 +0000 (07:34 +0000)] 
Merge the Readonly changes from trunk to the Perl-Critic-1.xxx
branch.  Specifically, merge r1581-1594.

14 years agoUpdate TODO with some clarifications and mental notes for my upcoming work
Chris Dolan [Sun, 8 Jul 2007 02:06:55 +0000 (02:06 +0000)] 
Update TODO with some clarifications and mental notes for my upcoming work

14 years agoNew policy: BuiltinFunctions::ProhibitComplexMappings
Chris Dolan [Sun, 8 Jul 2007 01:21:25 +0000 (01:21 +0000)] 
New policy: BuiltinFunctions::ProhibitComplexMappings
Self compliance with the new policy
Mention Chris Dolan's Perl Foundation grant in the main CREDITS
Minor spelling corrections

14 years agoFix P::C::Theme to work under Perl 5.6. The included version of
Elliot Shank [Sat, 7 Jul 2007 05:51:33 +0000 (05:51 +0000)] 
Fix P::C::Theme to work under Perl 5.6.  The included version of
Exporter doesn't export import().