Login
Elliot Shank [Sat, 8 Mar 2008 21:29:26 +0000 (21:29 +0000)]
Clean up some self-compliance issues now that MagicNumbers
is in core.
There's still issues with Utils::PPIRegexp and
ProhibitParensWithBuiltins: I can't come up with descriptive
names for these things. Help!
Elliot Shank [Sat, 8 Mar 2008 19:56:20 +0000 (19:56 +0000)]
Move ProhibitMagicNumbers from More to core.
Elliot Shank [Sat, 8 Mar 2008 16:09:46 +0000 (16:09 +0000)]
Bump P::C version to 1.082.
Elliot Shank [Sat, 8 Mar 2008 15:58:41 +0000 (15:58 +0000)]
Add a bunch of items related to Parameters to TODO.pod.
Elliot Shank [Sat, 8 Mar 2008 15:52:12 +0000 (15:52 +0000)]
Small fix to Changes.
Elliot Shank [Sat, 8 Mar 2008 15:46:14 +0000 (15:46 +0000)]
Fix some small problems in DEVELOPER.pod.
Elliot Shank [Sat, 8 Mar 2008 15:16:46 +0000 (15:16 +0000)]
Roll up changes in recent dev releases into the following
non-dev releases in Changes in order to make them easier to
read.
Prompted by
http://www.omnigroup.com/applications/omnigraffle/releasenotes/
being a royal pain to figure out and by Andy similarly
combining things in Ack's Changes.
Details on dev releases are still available to the general
populace via BackPAN.
Elliot Shank [Fri, 7 Mar 2008 20:43:53 +0000 (20:43 +0000)]
Add idea for -l/-L options for perlcritic.
Elliot Shank [Sun, 2 Mar 2008 19:34:51 +0000 (19:34 +0000)]
Update Changes for 1.081_006 release.
Elliot Shank [Sun, 2 Mar 2008 19:32:27 +0000 (19:32 +0000)]
Bump version to 1.081_006.
Elliot Shank [Sun, 2 Mar 2008 19:23:57 +0000 (19:23 +0000)]
I believe that I've got the PodSpelling problem whacked.
You still any error output of aspell, though, but the policy
now does a test run in initialize_if_enabled().
Elliot Shank [Sun, 2 Mar 2008 18:42:23 +0000 (18:42 +0000)]
Ok, PodSpelling doesn't fall over if something is wrong,
anymore, in a way that I'm satisfied with. However, in
this situation, we still fail tests.
Elliot Shank [Sun, 2 Mar 2008 18:17:08 +0000 (18:17 +0000)]
Update DEVELOPER.pod in terms of initialize_if_enabled().
Elliot Shank [Sun, 2 Mar 2008 16:25:06 +0000 (16:25 +0000)]
Trailing whitespace.
Elliot Shank [Sun, 2 Mar 2008 16:13:26 +0000 (16:13 +0000)]
Bring in ErrorHandling::RequireUseOfExceptions requirement
for t/40_criticize.t. Unfortunately, right now, this means
that an eval error is emitted, even when TEST_AUTHOR is not
set. I haven't found a solution for that that I'm happy
with.
Elliot Shank [Thu, 28 Feb 2008 04:55:35 +0000 (04:55 +0000)]
Bump copyright dates.
Elliot Shank [Wed, 27 Feb 2008 04:52:22 +0000 (04:52 +0000)]
Add the tools directory to the distribution, since it's
being advertized in DEVELOPER.pod.
Elliot Shank [Wed, 27 Feb 2008 04:45:50 +0000 (04:45 +0000)]
Cross reference the configuration classes in their POD.
Elliot Shank [Mon, 25 Feb 2008 01:56:14 +0000 (01:56 +0000)]
Now that all core policies use Parameters, re-enable
t/16_roundtrip_defaults.t.
Elliot Shank [Mon, 25 Feb 2008 01:54:32 +0000 (01:54 +0000)]
Remove old marker output in t/15_statistics.t.
Elliot Shank [Mon, 25 Feb 2008 01:40:38 +0000 (01:40 +0000)]
Make parameter description test no-longer TODO.
Elliot Shank [Mon, 25 Feb 2008 01:30:56 +0000 (01:30 +0000)]
Make Variables::ProhibitPunctuationVars use Parameters.
Elliot Shank [Mon, 25 Feb 2008 01:29:14 +0000 (01:29 +0000)]
Make Variables::ProhibitPackageVars use Parameters.
Elliot Shank [Mon, 25 Feb 2008 01:24:42 +0000 (01:24 +0000)]
Make ValuesAndExpressions::RequireNumberSeparators use
Parameters.
Elliot Shank [Mon, 25 Feb 2008 01:13:49 +0000 (01:13 +0000)]
Make ValuesAndExpressions::ProhibitInterpolationOfLiterals
use Parameters.
Elliot Shank [Mon, 25 Feb 2008 01:11:12 +0000 (01:11 +0000)]
Make ValuesAndExpressions::ProhibitCommaSeparatedStatements
use Parameters.
Elliot Shank [Mon, 25 Feb 2008 01:03:52 +0000 (01:03 +0000)]
Make ValuesAndExpressions::ProhibitLongChainsOfMethodCalls
use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:59:46 +0000 (00:59 +0000)]
Make
ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters
use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:51:13 +0000 (00:51 +0000)]
Make TestingAndDebugging::RequireTestLabels use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:49:36 +0000 (00:49 +0000)]
Make TestingAndDebugging::ProhibitProlongedStrictureOverride
use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:48:00 +0000 (00:48 +0000)]
Make TestingAndDebugging::ProhibitNoWarnings use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:46:18 +0000 (00:46 +0000)]
Make TestingAndDebugging::ProhibitNoStrict use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:32:01 +0000 (00:32 +0000)]
Make Subroutines::RequireFinalReturn use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:29:36 +0000 (00:29 +0000)]
Make Subroutines::RequireArgUnpacking use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:27:04 +0000 (00:27 +0000)]
Make Subroutines::ProhibitManyArgs use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:25:19 +0000 (00:25 +0000)]
Make Subroutines::ProhibitExcessComplexity use Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:10:58 +0000 (00:10 +0000)]
Make RegularExpressions::ProhibitComplexRegexes use
Parameters.
Elliot Shank [Mon, 25 Feb 2008 00:01:41 +0000 (00:01 +0000)]
Make NamingConventions::ProhibitAmbiguousNames use Parameters.
Elliot Shank [Sun, 24 Feb 2008 23:56:59 +0000 (23:56 +0000)]
Make Modules::RequireExplicitPackage use Parameters.
Elliot Shank [Sun, 24 Feb 2008 23:52:01 +0000 (23:52 +0000)]
Make Modules::ProhibitEvilModules use Parameters.
Elliot Shank [Sun, 24 Feb 2008 23:46:34 +0000 (23:46 +0000)]
Make Modules::ProhibitExcessMainComplexity use Parameters.
Elliot Shank [Sun, 24 Feb 2008 23:46:15 +0000 (23:46 +0000)]
Now that RequirePodSections uses Parameters, restore test in
t/01_config_bad_perlcriticrc.t.
Elliot Shank [Sun, 24 Feb 2008 16:26:24 +0000 (16:26 +0000)]
Make InputOutput::RequireBriefOpen use Parameters.
Elliot Shank [Sun, 24 Feb 2008 16:08:26 +0000 (16:08 +0000)]
Make Documentation::RequirePodSections use Parameters.
Elliot Shank [Sun, 24 Feb 2008 08:16:42 +0000 (08:16 +0000)]
Make Miscellanea::RequireRcsKeywords use Parameters.
Elliot Shank [Sun, 24 Feb 2008 08:13:45 +0000 (08:13 +0000)]
Make InputOutput::RequireCheckedSyscalls use Parameters.
Elliot Shank [Sun, 24 Feb 2008 07:55:34 +0000 (07:55 +0000)]
Make InputOutput::ProhibitBacktickOperators use Parameters.
Elliot Shank [Sun, 24 Feb 2008 07:53:08 +0000 (07:53 +0000)]
Make ErrorHandling::RequireCarping use Paremeters.
Elliot Shank [Sun, 24 Feb 2008 07:47:46 +0000 (07:47 +0000)]
Make Documentation::PodSpelling use Parameters.
Fix POD spelling problems.
PodSpelling had an eval in it without checking the value of
$EVAL_ERROR without a comment about why. I removed that,
but, of course, this may need to be put back due to the
problems this policy has in passing tests in broken
environments, but with a comment. Get that? With a
comment.
Elliot Shank [Sun, 24 Feb 2008 06:32:25 +0000 (06:32 +0000)]
Make ControlStructures::ProhibitPostfixControls use
Parameters.
Elliot Shank [Sun, 24 Feb 2008 06:03:36 +0000 (06:03 +0000)]
Make ControlStructures::ProhibitMutatingListFunctions use
Parameters.
Elliot Shank [Sun, 24 Feb 2008 06:01:25 +0000 (06:01 +0000)]
Make ControlStructures::ProhibitDeepNests use Parameters.
Elliot Shank [Sun, 24 Feb 2008 06:00:00 +0000 (06:00 +0000)]
Make ControlStructures::ProhibitCascadingIfElse use
Parameters.
Elliot Shank [Sun, 24 Feb 2008 05:57:55 +0000 (05:57 +0000)]
Make CodeLayout::RequireTidyCode use Parameters.
Elliot Shank [Sun, 24 Feb 2008 05:54:31 +0000 (05:54 +0000)]
Make CodeLayout::ProhibitQuotedWordLists use Parameters.
Elliot Shank [Sun, 24 Feb 2008 05:52:07 +0000 (05:52 +0000)]
Make CodeLayout::ProhibitHardTabs use Parameters.
Elliot Shank [Sun, 24 Feb 2008 05:46:11 +0000 (05:46 +0000)]
Make BuiltinFunctions::ProhibitComplexMappings use
Parameters.
Elliot Shank [Sat, 16 Feb 2008 23:21:35 +0000 (23:21 +0000)]
Remove Moose TODO.
Update Changes with parameters.
Elliot Shank [Sat, 16 Feb 2008 23:16:36 +0000 (23:16 +0000)]
Bring in the updated developer documentation. Needs to be reviewed
in terms of modern stuff.
Elliot Shank [Sat, 16 Feb 2008 23:01:01 +0000 (23:01 +0000)]
Merge changes to ProfilePrototype to take advantage the parameters
stuff.
Elliot Shank [Sat, 16 Feb 2008 20:50:35 +0000 (20:50 +0000)]
Merge Policies actually using PolicyParameter objects.
Elliot Shank [Sat, 16 Feb 2008 17:48:57 +0000 (17:48 +0000)]
Add Moose support to RequireUseWarnings.
Done during the Moose session at Frozen Perl '08.
Elliot Shank [Sat, 16 Feb 2008 17:41:03 +0000 (17:41 +0000)]
Add Moose support to RequireUseStrict.
Done during the Moose session at Frozen Perl '08.
Elliot Shank [Wed, 6 Feb 2008 15:11:08 +0000 (15:11 +0000)]
Fix self-compliance problems in PodSpelling.
Shame on you, Jeff. :]
Jeffrey Ryan Thalhammer [Mon, 14 Jan 2008 04:41:38 +0000 (04:41 +0000)]
Added "criticim-fatal" switch, which will make the criticism
pragma die if it finds any violations.
Elliot Shank [Sat, 5 Jan 2008 02:38:40 +0000 (02:38 +0000)]
Implement Modules::RequireNoMatchVarsWithUseEnglish.
Jeffrey Ryan Thalhammer [Tue, 1 Jan 2008 23:30:12 +0000 (23:30 +0000)]
According to https://rt.cpan.org/Ticket/Display.html?id=31972,
open2 is broken on win32 platforms. So I'm following the
pattern in Test::Spelling to avoid using open2.
Elliot Shank [Mon, 31 Dec 2007 00:43:56 +0000 (00:43 +0000)]
Update the P::C class diagram to include the change from
P::C::ConfigErrors to P::C::Exception::AggregateConfiguration.
Note that this shows the state of affairs as of the full
merge of the parameters stuff. The code actually on trunk
does not contain the Policy/PolicyParameter linkage yet.
Elliot Shank [Mon, 31 Dec 2007 00:05:28 +0000 (00:05 +0000)]
Sweep through core modules' POD, primarily concerned with the
module summary in the NAME section.
Elliot Shank [Sun, 30 Dec 2007 01:15:36 +0000 (01:15 +0000)]
Update P::C Changes.
Elliot Shank [Sun, 30 Dec 2007 01:09:04 +0000 (01:09 +0000)]
Bump P::C version to 1.081_005.
Elliot Shank [Sun, 30 Dec 2007 01:03:22 +0000 (01:03 +0000)]
Switch skip test in t/20_policy_podspelling.t to use "Silly".
Apparently, "test" is a valid German word. Need to pick
something that has identical British and American spellings,
yet doesn't exist in other languages.
Elliot Shank [Sat, 29 Dec 2007 21:04:50 +0000 (21:04 +0000)]
Add policies to P::C TODO.
Elliot Shank [Sat, 29 Dec 2007 20:54:27 +0000 (20:54 +0000)]
Put the ControlStructires::ProhibitPostfixControls change into
Changes.
Elliot Shank [Sat, 29 Dec 2007 20:35:57 +0000 (20:35 +0000)]
Begin the parameters merge with PolicyParameter and its
Behaviors. No tests merged yet because they depend upon
other changes.
Elliot Shank [Sat, 29 Dec 2007 20:19:36 +0000 (20:19 +0000)]
Fix PodSpelling problem with ControlStructures::ProhibitPostfixControls.
Elliot Shank [Sat, 29 Dec 2007 19:22:01 +0000 (19:22 +0000)]
Add generation of the "resources" entry in META.yml to the
P::C Build.PL.
Andrew Moore [Sat, 29 Dec 2007 19:01:38 +0000 (19:01 +0000)]
changes to address RT ticket 29540:
* added a configuration directive to ControlStructires::ProhibitPostfixControls
to allow users to set list of functions that can have a postfix 'if' after them.
* cleaned up test script a bit. Looks like it had leftovers
from conversion to new testing method.
M Perl-Critic/t/ControlStructures/ProhibitPostfixControls.run
M Perl-Critic/lib/Perl/Critic/Policy/ControlStructures/ProhibitPostfixControls.pm
Elliot Shank [Mon, 24 Dec 2007 05:16:20 +0000 (05:16 +0000)]
Finish conversion to exceptions of P::C core.
Elliot Shank [Mon, 24 Dec 2007 01:21:04 +0000 (01:21 +0000)]
Convert P::C::TestUtils to using exceptions.
Elliot Shank [Sat, 22 Dec 2007 22:35:35 +0000 (22:35 +0000)]
Fix RT #30388 ValuesAndExpressions::ProhibitVersionStrings by
making an exception for "use lib".
Elliot Shank [Thu, 20 Dec 2007 16:31:36 +0000 (16:31 +0000)]
Yet again, redo r2040.
Elliot Shank [Thu, 20 Dec 2007 16:23:22 +0000 (16:23 +0000)]
Fix ProhibitComplexRegexps violations.
Elliot Shank [Thu, 20 Dec 2007 16:04:39 +0000 (16:04 +0000)]
And undo r2040 /again/.
Elliot Shank [Thu, 20 Dec 2007 16:02:14 +0000 (16:02 +0000)]
Update P::C changes.
Elliot Shank [Thu, 20 Dec 2007 16:00:02 +0000 (16:00 +0000)]
Bump P::C version to 1.081_004.
Elliot Shank [Thu, 20 Dec 2007 15:53:21 +0000 (15:53 +0000)]
Hopefully the final bit to restore 5.6 compatability: Replace use of
Unicode property \p{...} escapes with POSIC character classes, [[:...:]].
Elliot Shank [Tue, 18 Dec 2007 17:51:17 +0000 (17:51 +0000)]
Remove ampersands from @EXPORT_OK elements in P::C::Utils::PPIRegexp.
Remember the conflict we had with Exporter and Readonly?
Elliot Shank [Sun, 16 Dec 2007 21:31:05 +0000 (21:31 +0000)]
And reundo r2040.
Elliot Shank [Sun, 16 Dec 2007 21:13:29 +0000 (21:13 +0000)]
Bump P::C version to 1.081_003.
Elliot Shank [Sun, 16 Dec 2007 21:10:57 +0000 (21:10 +0000)]
Add Modules::RequireUseVersion and
Modules::RequireThreePartVersion to TODO.
Elliot Shank [Sun, 16 Dec 2007 20:56:21 +0000 (20:56 +0000)]
Update P::C Changes.
Elliot Shank [Sun, 16 Dec 2007 20:51:46 +0000 (20:51 +0000)]
And redo r2040.
Elliot Shank [Sun, 16 Dec 2007 20:46:52 +0000 (20:46 +0000)]
Oops. Missed some usage of IsUppercase.
Elliot Shank [Sun, 16 Dec 2007 19:59:17 +0000 (19:59 +0000)]
Doh! "require" is runtime, which means the compiler keeps going
to the "use" statements. Put "require 5.006001" into BEGIN block
in Build.PL and Makefile.PL in the effort to stop testing under
5.005005.
Elliot Shank [Sun, 16 Dec 2007 19:34:57 +0000 (19:34 +0000)]
Since 1.081_002 is out, re-undo r2040.
Elliot Shank [Sun, 16 Dec 2007 19:24:48 +0000 (19:24 +0000)]
Put release date into Changes for 1.081_002.
Elliot Shank [Sun, 16 Dec 2007 19:19:10 +0000 (19:19 +0000)]
Redo r2040, again temporarily, in order to get a development
release out.
Elliot Shank [Sun, 16 Dec 2007 19:14:12 +0000 (19:14 +0000)]
Bump P::C version to 1.081_002 in order to test whether we're
compatible with perl 5.6 now.
Elliot Shank [Sun, 16 Dec 2007 18:59:56 +0000 (18:59 +0000)]
Use \p{IsUpper} and \b{IsLower} instead of \p{IsUppercase} and \b{IsLowercase}
in order to restore compatibility with perl 5.6.