Login
gknop/Perl-Critic.git
12 years agoFixed more self-compliance
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 11:07:10 +0000 (11:07 +0000)] 
Fixed more self-compliance

12 years agoMore self compliance
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 10:54:11 +0000 (10:54 +0000)] 
More self compliance

12 years agoGet rid of that Debian-whatever file. I think it
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 10:04:46 +0000 (10:04 +0000)] 
Get rid of that Debian-whatever file.  I think it
gets produced by the Kwailitee tests.

12 years agoFixed up self-compliance issues in NamingConventions::Capitalization.
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 10:02:12 +0000 (10:02 +0000)] 
Fixed up self-compliance issues in NamingConventions::Capitalization.

12 years agoFixed breakage that started when the names of some
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 09:53:23 +0000 (09:53 +0000)] 
Fixed breakage that started when the names of some
of the test scripts were changed.

12 years agoPulled all the 'no critic' handling code out of Critic.pm
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 09:26:16 +0000 (09:26 +0000)] 
Pulled all the 'no critic' handling code out of Critic.pm
and put it into Document.pm.  The internals are still kinda
ugly, but the interface is much nicer (I think).

12 years agoJust comment formatting changes.
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 09:25:02 +0000 (09:25 +0000)] 
Just comment formatting changes.

12 years agoMore self-compliance.
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 09:24:05 +0000 (09:24 +0000)] 
More self-compliance.

12 years agoTurn off Capitalization policy for now. It is making too much noise
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 09:00:15 +0000 (09:00 +0000)] 
Turn off Capitalization policy for now.  It is making too much noise

12 years agoSelf-compliance with ProhibitUnrestrictedNoCritic
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 08:59:40 +0000 (08:59 +0000)] 
Self-compliance with ProhibitUnrestrictedNoCritic

12 years agoWoops, I left a naked subroutine out there.
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 07:01:26 +0000 (07:01 +0000)] 
Woops, I left a naked subroutine out there.

Also re-arranged some code slightly.  I do like to take advantage of
the postfix-if-with-flow-control-statements rule.

12 years agoVanquised can_be_disabled() method.
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 06:52:49 +0000 (06:52 +0000)] 
Vanquised can_be_disabled() method.

12 years agoResolved failing test cases for Miscellanea::ProhibitUnrestrictedNoCritic. Next...
Jeffrey Ryan Thalhammer [Sun, 26 Oct 2008 06:36:18 +0000 (06:36 +0000)] 
Resolved failing test cases for Miscellanea::ProhibitUnrestrictedNoCritic.  Next, I'll remove the can_be_disabled() method.

12 years agoAdd a check on myself: add a test that complains if any of the
Elliot Shank [Mon, 20 Oct 2008 05:00:43 +0000 (05:00 +0000)] 
Add a check on myself: add a test that complains if any of the
optional modules aren't installed.

12 years agoFailing test with ProhibitParensWithBuiltins that I'm not sure what to
Elliot Shank [Sat, 18 Oct 2008 01:58:36 +0000 (01:58 +0000)] 
Failing test with ProhibitParensWithBuiltins that I'm not sure what to
do with.  Treat "int" as an operator?

12 years agoRename the t/20_policy_*.t tests to include underscores so that the
Elliot Shank [Thu, 16 Oct 2008 02:36:31 +0000 (02:36 +0000)] 
Rename the t/20_policy_*.t tests to include underscores so that the
names are notlikethis.

12 years agoDisable Modules::ProhibitEvilModules if there aren't any evil modules.
Elliot Shank [Thu, 16 Oct 2008 02:30:06 +0000 (02:30 +0000)] 
Disable Modules::ProhibitEvilModules if there aren't any evil modules.

12 years agoAdd subroutine name to violation descriptions for
Elliot Shank [Thu, 16 Oct 2008 00:51:46 +0000 (00:51 +0000)] 
Add subroutine name to violation descriptions for
Subroutines::ProhibitExcessComplexity.  Optimistically, it handles the
case of anonymous subroutines, in case PPI ever handles them.  :]

RT #40070, thanks to Andreas Koenig.

12 years agoLinks to Test::P::C.
Elliot Shank [Tue, 14 Oct 2008 03:12:14 +0000 (03:12 +0000)] 
Links to Test::P::C.

12 years agoMissed RegularExpressions::ProhibitCaptureWithoutTest in earlier bugs
Elliot Shank [Tue, 14 Oct 2008 02:55:38 +0000 (02:55 +0000)] 
Missed RegularExpressions::ProhibitCaptureWithoutTest in earlier bugs
documentation move commit.

12 years agoAdd small links HTML page for holding links to *nix P::C packages and
Elliot Shank [Tue, 14 Oct 2008 02:53:52 +0000 (02:53 +0000)] 
Add small links HTML page for holding links to *nix P::C packages and
other things.

12 years agoMove policy bugs from TODO.pod to the actual Policies. Users should
Elliot Shank [Tue, 14 Oct 2008 01:19:23 +0000 (01:19 +0000)] 
Move policy bugs from TODO.pod to the actual Policies.  Users should
be aware of limitations.

12 years agoDelete dead code from NamingConventions::ProhibitAmbiguousNames.
Elliot Shank [Tue, 14 Oct 2008 00:48:48 +0000 (00:48 +0000)] 
Delete dead code from NamingConventions::ProhibitAmbiguousNames.

12 years agoCode cleanups to comply with NamingConventions::Capitalization.
Elliot Shank [Tue, 14 Oct 2008 00:40:25 +0000 (00:40 +0000)] 
Code cleanups to comply with NamingConventions::Capitalization.
Amazing what some of this turned up, e.g. leftover, unused variables
from prior to conversion to use Policy Parameters.

12 years agoAdd exceptions for the standard tie subroutines to
Elliot Shank [Tue, 14 Oct 2008 00:30:32 +0000 (00:30 +0000)] 
Add exceptions for the standard tie subroutines to
NamingConventions::Capitalization and borrow code from unreleased
PPI::Statement::Variable to get real variable names in the case of
"local" statements.

12 years agoAnd $P::C::Policy::FORMAT bites the dust too.
Elliot Shank [Tue, 14 Oct 2008 00:18:43 +0000 (00:18 +0000)] 
And $P::C::Policy::FORMAT bites the dust too.

12 years ago$P::C::Violation::FORMAT loses to NamingConventions::Capitalization.
Elliot Shank [Tue, 14 Oct 2008 00:12:27 +0000 (00:12 +0000)] 
$P::C::Violation::FORMAT loses to NamingConventions::Capitalization.
Oh, darn.

12 years agoFix subroutine capitalization in Modules::RequireVersionVar and mark
Elliot Shank [Mon, 13 Oct 2008 22:30:19 +0000 (22:30 +0000)] 
Fix subroutine capitalization in Modules::RequireVersionVar and mark
TODO test as no longer TODO in t/Modules/RequireVersionVar.run.

12 years agoAdd AUTOLOAD exceptions to NamingConventions::Capitalization and
Elliot Shank [Mon, 13 Oct 2008 22:17:00 +0000 (22:17 +0000)] 
Add AUTOLOAD exceptions to NamingConventions::Capitalization and
include the kind of name in violation descriptions.

12 years agoAdd explanation to RequireNoMatchVarsWithUseEnglish about merely not
Elliot Shank [Mon, 13 Oct 2008 21:48:32 +0000 (21:48 +0000)] 
Add explanation to RequireNoMatchVarsWithUseEnglish about merely not
importing any of the match variables not being good enough to prevent
performance problems.

12 years agoMore fully state that development is done using Module::Build.
Elliot Shank [Sat, 11 Oct 2008 23:44:02 +0000 (23:44 +0000)] 
More fully state that development is done using Module::Build.

12 years agoAdd some draft notes about how we do P::C releases
Chris Dolan [Sat, 11 Oct 2008 22:41:03 +0000 (22:41 +0000)] 
Add some draft notes about how we do P::C releases

12 years agoRT #39787 is wrong. RequireNoMatchVarsWithUseEnglish is correct, as
Elliot Shank [Sat, 11 Oct 2008 03:40:51 +0000 (03:40 +0000)] 
RT #39787 is wrong.  RequireNoMatchVarsWithUseEnglish is correct, as
is.

12 years agoHandle the __PACKAGE__->_foo() case in ProtectPrivateSubs.
Elliot Shank [Sat, 11 Oct 2008 02:41:20 +0000 (02:41 +0000)] 
Handle the __PACKAGE__->_foo() case in ProtectPrivateSubs.

12 years agoAdd failing test for __PACKAGE__->_foo() for ProtectPrivateSubs.
Elliot Shank [Fri, 10 Oct 2008 00:35:51 +0000 (00:35 +0000)] 
Add failing test for __PACKAGE__->_foo() for ProtectPrivateSubs.

12 years agoAdd a bunch of stuff to TODO.
Elliot Shank [Fri, 10 Oct 2008 00:33:53 +0000 (00:33 +0000)] 
Add a bunch of stuff to TODO.

12 years agoAdd a :single_case tag to NamingConventions::Capitalization and
Elliot Shank [Mon, 6 Oct 2008 06:51:53 +0000 (06:51 +0000)] 
Add a :single_case tag to NamingConventions::Capitalization and
rewrite its POD.

12 years agoTest for "package main" in NamingConventions::Capitalization
Chris Dolan [Sat, 4 Oct 2008 00:30:10 +0000 (00:30 +0000)] 
Test for "package main" in NamingConventions::Capitalization

12 years agoFailing test for Modules::RequireNoMatchVarsWithUseEnglish from
Elliot Shank [Fri, 3 Oct 2008 12:01:56 +0000 (12:01 +0000)] 
Failing test for Modules::RequireNoMatchVarsWithUseEnglish from
RT #39787.

12 years agoAdd "main" to the default package name exemptions to
Elliot Shank [Fri, 3 Oct 2008 11:40:13 +0000 (11:40 +0000)] 
Add "main" to the default package name exemptions to
NamingConventions::Capitalization.

12 years agoSimplify the regexes for the default global variables that are exempt
Elliot Shank [Mon, 29 Sep 2008 01:02:53 +0000 (01:02 +0000)] 
Simplify the regexes for the default global variables that are exempt
from Capitalization.

12 years agoThe big NamingConventions::Capitalization rejiggering. Need to make
Elliot Shank [Mon, 29 Sep 2008 00:44:22 +0000 (00:44 +0000)] 
The big NamingConventions::Capitalization rejiggering.  Need to make
NamingConventions/Capitalization.run be generated.  But right now, my
brain is fried.

12 years agoAdd test for Statement::Include::module_version() in
Elliot Shank [Sun, 28 Sep 2008 22:29:12 +0000 (22:29 +0000)] 
Add test for Statement::Include::module_version() in
xt/author/81_ppi_problems.t.

12 years agoFix self compliance in t/05_utils_ppi.t and Utils::PPI.
Elliot Shank [Sun, 28 Sep 2008 21:41:14 +0000 (21:41 +0000)] 
Fix self compliance in t/05_utils_ppi.t and Utils::PPI.

12 years agoAdd cleaned up versions of Utils::PPI::is_subroutine_declaration() and
Elliot Shank [Sun, 28 Sep 2008 20:54:12 +0000 (20:54 +0000)] 
Add cleaned up versions of Utils::PPI::is_subroutine_declaration() and
is_in_subroutine() from Schwern.

12 years agoAdd a test file for things we want from PPI.
Elliot Shank [Sun, 28 Sep 2008 20:06:28 +0000 (20:06 +0000)] 
Add a test file for things we want from PPI.

12 years agoRename Variables::ProhibitReusedVarNames to Variables::ProhibitReusedNames
Chris Dolan [Sun, 28 Sep 2008 15:07:45 +0000 (15:07 +0000)] 
Rename Variables::ProhibitReusedVarNames to Variables::ProhibitReusedNames

12 years agoUpdate threading comment in TODO.pod.
Elliot Shank [Sun, 28 Sep 2008 14:15:22 +0000 (14:15 +0000)] 
Update threading comment in TODO.pod.

12 years agoAdd threading idea to TODO.pod.
Elliot Shank [Sun, 28 Sep 2008 14:13:38 +0000 (14:13 +0000)] 
Add threading idea to TODO.pod.

12 years agoSome failing test cases for ProhibitUnrestrictedNoCritic.
Jeffrey Ryan Thalhammer [Sun, 28 Sep 2008 06:34:18 +0000 (06:34 +0000)] 
Some failing test cases for ProhibitUnrestrictedNoCritic.

12 years agoself-compliance with Variables::ProhibitReusedVarNames
Chris Dolan [Sun, 28 Sep 2008 06:16:02 +0000 (06:16 +0000)] 
self-compliance with Variables::ProhibitReusedVarNames

12 years agoVariables::ProhibitReusedVarNames bug fix (PPI returns '' instead of undef for false...)
Chris Dolan [Sun, 28 Sep 2008 05:55:46 +0000 (05:55 +0000)] 
Variables::ProhibitReusedVarNames bug fix (PPI returns '' instead of undef for false...)

12 years agoNew policy Variables::ProhibitReusedVarNames
Chris Dolan [Sun, 28 Sep 2008 04:47:12 +0000 (04:47 +0000)] 
New policy Variables::ProhibitReusedVarNames

12 years agoSelf-compliance with ProhibitUnrestrictedNoCritic
Jeffrey Ryan Thalhammer [Sun, 28 Sep 2008 03:23:29 +0000 (03:23 +0000)] 
Self-compliance with ProhibitUnrestrictedNoCritic

12 years agoAdd can_be_disabled() to the trusted method list
Jeffrey Ryan Thalhammer [Sun, 28 Sep 2008 03:10:17 +0000 (03:10 +0000)] 
Add can_be_disabled() to the trusted method list

12 years agoCreated a new Policy to prohibit an unrestricted ## no critic.
Jeffrey Ryan Thalhammer [Sun, 28 Sep 2008 02:32:42 +0000 (02:32 +0000)] 
Created a new Policy to prohibit an unrestricted ## no critic.
I was able to implement this as a policy rather than a
command-line switch by adding a method to the Policy
base class that indicates whether the policy can be disabled.

I can think of a few other applications for this new method,
such as policy that prohibits you from disabling certain other
policies.  For example, shops using Test::Perl::Critic
may wish to prevent unruly developers from locally disabling
some policies that they feel are irrefutable.  I realize
that it isn't very kind, but I've been in situations where I
wished that I could do that.

12 years agoRename is_document_exempt() to prepare_to_scan_document().
Elliot Shank [Sat, 27 Sep 2008 20:24:21 +0000 (20:24 +0000)] 
Rename is_document_exempt() to prepare_to_scan_document().

12 years agoUpdate autodie support to v1.994.
Elliot Shank [Sat, 27 Sep 2008 04:24:10 +0000 (04:24 +0000)] 
Update autodie support to v1.994.

12 years agoChange ppidump to emit element locations.
Elliot Shank [Sat, 27 Sep 2008 02:29:54 +0000 (02:29 +0000)] 
Change ppidump to emit element locations.

13 years agoAdd TODO to enable removing "## no critic" markers.
Elliot Shank [Thu, 25 Sep 2008 01:52:08 +0000 (01:52 +0000)] 
Add TODO to enable removing "## no critic" markers.

13 years agoFix date prototype at the top of Changes. Yeah, it annoyed me. :]
Elliot Shank [Wed, 17 Sep 2008 12:37:58 +0000 (12:37 +0000)] 
Fix date prototype at the top of Changes.  Yeah, it annoyed me.  :]

13 years agoPut caveat about autodie support into Changes.
Elliot Shank [Wed, 17 Sep 2008 12:32:07 +0000 (12:32 +0000)] 
Put caveat about autodie support into Changes.

13 years agoAdd autodie support to the InputOutput::RequireChecked* policies.
Elliot Shank [Wed, 17 Sep 2008 03:46:23 +0000 (03:46 +0000)] 
Add autodie support to the InputOutput::RequireChecked* policies.

13 years agoAllow specification of violation descriptions in ProhibitEvilModules.
Elliot Shank [Sun, 14 Sep 2008 08:04:54 +0000 (08:04 +0000)] 
Allow specification of violation descriptions in ProhibitEvilModules.

13 years agoChange Modules::ProhibitEvilModules::initialize_if_enabled() into a
Elliot Shank [Sun, 14 Sep 2008 05:47:35 +0000 (05:47 +0000)] 
Change Modules::ProhibitEvilModules::initialize_if_enabled() into a
custom parser for the "modules" option in preparation for providing an
means for specifying the violation description.

13 years agoChange Modules::ProhibitEvilModules to include the bad module name in
Elliot Shank [Sun, 14 Sep 2008 05:25:59 +0000 (05:25 +0000)] 
Change Modules::ProhibitEvilModules to include the bad module name in
the violation description.

13 years agoSmall POD addition to ControlStructures::ProhibitPostfixControls.
Elliot Shank [Sun, 14 Sep 2008 05:24:43 +0000 (05:24 +0000)] 
Small POD addition to ControlStructures::ProhibitPostfixControls.

13 years agoRewrap the POD in NamingConventions::Capitalization and
Elliot Shank [Sun, 14 Sep 2008 05:23:23 +0000 (05:23 +0000)] 
Rewrap the POD in NamingConventions::Capitalization and
put copyright for Schwern in there as well.

13 years agoUpdated docs about EPIC
Jeffrey Ryan Thalhammer [Mon, 8 Sep 2008 03:34:27 +0000 (03:34 +0000)] 
Updated docs about EPIC

13 years agoUpdate $VERSION in NamingConventions::Capitalization.
Elliot Shank [Sun, 7 Sep 2008 10:52:55 +0000 (10:52 +0000)] 
Update $VERSION in NamingConventions::Capitalization.

13 years agoRestore Schwern's Capitalization policy.
Elliot Shank [Sun, 7 Sep 2008 10:51:39 +0000 (10:51 +0000)] 
Restore Schwern's Capitalization policy.

13 years agoWhoops. Missed some version number changes in the 1.093_001
Elliot Shank [Sun, 7 Sep 2008 10:39:18 +0000 (10:39 +0000)] 
Whoops.  Missed some version number changes in the 1.093_001
change.

13 years agoRelease P::C 1.093_001 so that I can get access to the v1.093_001 v1.093_01
Elliot Shank [Sun, 7 Sep 2008 10:33:32 +0000 (10:33 +0000)] 
Release P::C 1.093_001 so that I can get access to the
RequireRcsKeywords fix at work.

13 years agoFix PodSpelling in RequireInterpolationOfMetachars.
Elliot Shank [Sun, 7 Sep 2008 10:00:19 +0000 (10:00 +0000)] 
Fix PodSpelling in RequireInterpolationOfMetachars.

13 years agoUse is_document_exempt() RequireExplicitPackage and
Elliot Shank [Sun, 7 Sep 2008 09:53:56 +0000 (09:53 +0000)] 
Use is_document_exempt() RequireExplicitPackage and
RequirePackageMatchesPodName.

13 years agoFix RequireFilenameMatchesPackage in terms of programs.
Elliot Shank [Sun, 7 Sep 2008 09:32:30 +0000 (09:32 +0000)] 
Fix RequireFilenameMatchesPackage in terms of programs.
Patch from Schwern in RT #39024.

13 years agoAdd test case to RequireEndWithOne.run from Schwern's
Elliot Shank [Sun, 7 Sep 2008 09:22:09 +0000 (09:22 +0000)] 
Add test case to RequireEndWithOne.run from Schwern's
patch in RT #39024.

13 years agoIn partial response to Schwern's patch for "non-program"
Elliot Shank [Sun, 7 Sep 2008 08:59:38 +0000 (08:59 +0000)] 
In partial response to Schwern's patch for "non-program"
Policies, add P::C::Policy::is_document_exempt() (which
I've wanted for a while).

13 years agoDocument the rcs_keywords option for
Elliot Shank [Sun, 7 Sep 2008 08:04:58 +0000 (08:04 +0000)] 
Document the rcs_keywords option for
RequireInterpolationOfMetachars.

13 years agoAllow RequireRcsKeywords to find things after __END__.
Elliot Shank [Sun, 7 Sep 2008 06:51:36 +0000 (06:51 +0000)] 
Allow RequireRcsKeywords to find things after __END__.

13 years agoBumped VERSION to 1.092. v1.092
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 16:43:48 +0000 (16:43 +0000)] 
Bumped VERSION to 1.092.

13 years agoThere were POD errors in the release that I just made,
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 16:25:20 +0000 (16:25 +0000)] 
There were POD errors in the release that I just made,
so I'm backing out Schwern's new policy again so I can
make another release.

13 years agoFixing errors in POD that were exposed in the last
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 16:03:18 +0000 (16:03 +0000)] 
Fixing errors in POD that were exposed in the last
release, thanks to CPAN testers.

13 years agoSome tweaks to my Ant build script. Since I use macports, much of my stuff is instal...
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 05:40:05 +0000 (05:40 +0000)] 
Some tweaks to my Ant build script.  Since I use macports, much of my stuff is installed in /opt/local/bin.  So I need that to be in the path for things like aspell and cover, which are needed during some of the build steps.

13 years agoAdding back in Schwern's Capitalization policy.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 05:26:07 +0000 (05:26 +0000)] 
Adding back in Schwern's Capitalization policy.

13 years agoBumped VERSION to 1.091 v1.091
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 04:36:59 +0000 (04:36 +0000)] 
Bumped VERSION to 1.091

13 years agoCleaning up my trailing whitespace. Damn Eclipse. I guess nobody is perfect.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 04:36:02 +0000 (04:36 +0000)] 
Cleaning up my trailing whitespace.  Damn Eclipse.  I guess nobody is perfect.

13 years agoUndoing the patch for Schwern's capitalization policy.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 04:12:00 +0000 (04:12 +0000)] 
Undoing the patch for Schwern's capitalization policy.
We'll put this back in after the release.

13 years agoMarked some failing tests as TODO, so I can go ahead with release. Will fix these...
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 03:36:18 +0000 (03:36 +0000)] 
Marked some failing tests as TODO, so I can go ahead with release.  Will fix these later.

13 years agoFurther cleanup after moving that policy to P-C-More.
Jeffrey Ryan Thalhammer [Tue, 2 Sep 2008 03:19:56 +0000 (03:19 +0000)] 
Further cleanup after moving that policy to P-C-More.

13 years agoUndo Schwern's changes in the last patch to the
Elliot Shank [Thu, 28 Aug 2008 13:07:45 +0000 (13:07 +0000)] 
Undo Schwern's changes in the last patch to the
ProhibitMixedCase* policies which changed their PBP page
numbers and increased their severities from lowest to low.

He was correct in his original assessment that these
policies don't really do anything with regard to PBP section
3.5.  These do apply the rules in section 3.6, however.

Also, since these policies deal with cosmetic issues, they
should remain at the lowest severity by default.

13 years agoApply Schwern's NamingConventions::Capitalization patch from
Elliot Shank [Thu, 28 Aug 2008 13:01:05 +0000 (13:01 +0000)] 
Apply Schwern's NamingConventions::Capitalization patch from
RT #38673.

13 years agoUpdate Changes file with latest bug fix.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 17:52:05 +0000 (17:52 +0000)] 
Update Changes file with latest bug fix.

13 years agoI think I've finally fixed the problem of false-positives coming from leading tabs...
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 17:46:06 +0000 (17:46 +0000)] 
I think I've finally fixed the problem of false-positives coming from leading tabs inside qw() statements and regexes.

13 years agoUpdate TODO list.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:24:17 +0000 (03:24 +0000)] 
Update TODO list.

13 years agoUpdated changes to reflect relocation of Policy.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:06:48 +0000 (03:06 +0000)] 
Updated changes to reflect relocation of Policy.

13 years agoMoving the test case for RequireConstantOnLeftSideOfEquality too.
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 03:02:19 +0000 (03:02 +0000)] 
Moving the test case for RequireConstantOnLeftSideOfEquality too.

13 years agoFinally decided to move RequireConstantOnLeftSideOfEquality to
Jeffrey Ryan Thalhammer [Wed, 27 Aug 2008 02:59:41 +0000 (02:59 +0000)] 
Finally decided to move RequireConstantOnLeftSideOfEquality to
P-C-More.  This is just too controversial and pesky to put in the
core.  If I can come up with a better version of the policy that
actually finds real bugs (as Chris suggested), then I'll put it in
core.

13 years agoFixed ProhibitHardTabs so that it would allow leading tabs
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 11:01:13 +0000 (11:01 +0000)] 
Fixed ProhibitHardTabs so that it would allow leading tabs
in qw(), regexen, and virtually any other token.  I'm not
sure this is what we really want.  For reference,
https://rt.cpan.org/Ticket/Display.html?id=32440.  I
couldn't tell from Elliot's comments what the "correct"
solution is.  But I'm sure he'll enlighten me soon
enough.

13 years agoEnhanced the -doc feature to take advantage of the
Jeffrey Ryan Thalhammer [Sun, 24 Aug 2008 08:58:14 +0000 (08:58 +0000)] 
Enhanced the -doc feature to take advantage of the
-pager feature that Schwern wrote.  To do this, I
needed to change up when the options are dashified.
Now, they are dashified immediately after GetOpt
pulls them out of @ARGV.  I think this is an
improvement because you don't have to worry
about whether the %opts hash has been dashified
yet.