Self-compliance with ProhibitUnrestrictedNoCritic

diff --git a/lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm b/lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm
index 43b9b72..e6afdad 100644 (file)
--- a/lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm
+++ b/lib/Perl/Critic/Policy/CodeLayout/RequireTidyCode.pm
@@ -77,7 +77,7 @@ sub violates {
     $source =~ s{ \s+ \Z}{\n}xms;
 
     # Remove the shell fix code from the top of program, if applicable
-    ## no critic(ProhibitComplexRegexes)
+    ## no critic (ProhibitComplexRegexes)
     my $shebang_re = qr< [#]! [^\015\012]+ [\015\012]+ >xms;
     my $shell_re   = qr<eval [ ] 'exec [ ] [^\015\012]* [ ] \$0 [ ] \${1[+]"\$@"}'
                         [ \t]*[\012\015]+ [ \t]* if [^\015\012]+ [\015\012]+ >xms;
@@ -91,7 +91,7 @@ sub violates {
     # another program.  Also, we need to override the
     # stdout and stderr redirects that the user may have
     # configured in their .perltidyrc file.
-    local @ARGV = qw(-nst -nse);  ## no critic
+    local @ARGV = qw(-nst -nse);
 
     # Trap Perl::Tidy errors, just in case it dies
     my $eval_worked = eval {

diff --git a/lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm b/lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm
index 3aaf983..77c53c7 100644 (file)
--- a/lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm
+++ b/lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm
@@ -21,7 +21,7 @@ our $VERSION = '1.093_01';
 #-----------------------------------------------------------------------------
 
 Readonly::Scalar my $DESC => q{Symbols are exported by default};
-Readonly::Scalar my $EXPL => q{Use '@EXPORT_OK' or '%EXPORT_TAGS' instead};  ## no critic
+Readonly::Scalar my $EXPL => q{Use '@EXPORT_OK' or '%EXPORT_TAGS' instead};  ## no critic (RequireInterpolation)
 
 #-----------------------------------------------------------------------------
 

diff --git a/lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm b/lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm
index 8c6f24a..8294fbf 100644 (file)
--- a/lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm
+++ b/lib/Perl/Critic/Policy/Modules/RequireVersionVar.pm
@@ -21,7 +21,7 @@ our $VERSION = '1.093_01';
 
 #-----------------------------------------------------------------------------
 
-Readonly::Scalar my $DESC => q{No "VERSION" variable found};
+Readonly::Scalar my $DESC => q{No "$VERSION" variable found}; ## no critic (RequireInterpolation)
 Readonly::Scalar my $EXPL => [ 404 ];
 
 #-----------------------------------------------------------------------------
@@ -44,7 +44,7 @@ sub violates {
 
 #-----------------------------------------------------------------------------
 
-sub _is_VERSION_declaration {  ##no critic(ArgUnpacking)
+sub _is_VERSION_declaration {  ## no critic (ArgUnpacking)
     return 1 if _is_our_VERSION(@_);
     return 1 if _is_vars_VERSION(@_);
     return 1 if _is_package_VERSION(@_);
@@ -58,7 +58,7 @@ sub _is_our_VERSION {
     my (undef, $elem) = @_;
     $elem->isa('PPI::Statement::Variable') || return 0;
     $elem->type() eq 'our' || return 0;
-    return any { $_ eq '$VERSION' } $elem->variables(); ## no critic
+    return any { $_ eq '$VERSION' } $elem->variables(); ## no critic (RequireInterpolation)
 }
 
 #-----------------------------------------------------------------------------

diff --git a/lib/Perl/Critic/Utils.pm b/lib/Perl/Critic/Utils.pm
index a5a4f9c..9c1beed 100644 (file)
--- a/lib/Perl/Critic/Utils.pm
+++ b/lib/Perl/Critic/Utils.pm
@@ -238,7 +238,7 @@ Readonly::Hash my %PRECEDENCE_OF => (
 ## use critic
 #-----------------------------------------------------------------------------
 
-sub hashify {  ##no critic(ArgUnpacking)
+sub hashify {  ## no critic (ArgUnpacking)
     return map { $_ => 1 } @_;
 }
 
@@ -246,7 +246,7 @@ sub hashify {  ##no critic(ArgUnpacking)
 
 sub interpolate {
     my ( $literal ) = @_;
-    return eval "\"$literal\"";  ## no critic 'StringyEval';
+    return eval "\"$literal\"";  ## no critic (StringyEval);
 }
 
 #-----------------------------------------------------------------------------