Login
perlcritic wasn't letting you use the %P placeholder in the verbose format specification.
authorJeffrey Ryan Thalhammer <jeff@imaginative-software.com>
Thu, 20 Sep 2007 06:20:55 +0000 (06:20 +0000)
committerJeffrey Ryan Thalhammer <jeff@imaginative-software.com>
Thu, 20 Sep 2007 06:20:55 +0000 (06:20 +0000)
I should probably factor out the list of placeholders into a package var to avoid duplication.

-lThis line, and those below, will be ignored--

M    perlcritic

bin/perlcritic

index 7441346..8e836e3 100755 (executable)
@@ -125,7 +125,7 @@ sub _validate_options {
         $msg .= qq{Warning: Cannot use -noprofile with -profile option.\n};
     }
 
-    if ( $opts{verbose} && $opts{verbose} !~ m{(?: \d+ | %[mfFlcedrps] )}mx) {
+    if ( $opts{verbose} && $opts{verbose} !~ m{(?: \d+ | %[mfFlcedrpPs] )}mx) {
         $msg .= qq{Warning: -verbose arg "$opts{verbose}" looks odd.  };
         $msg .= qq{Perhaps you meant to say "-verbose 3 $opts{verbose}"\n};
     }