Login
RT #39787 is wrong. RequireNoMatchVarsWithUseEnglish is correct, as
authorElliot Shank <perl@galumph.com>
Sat, 11 Oct 2008 03:40:51 +0000 (03:40 +0000)
committerElliot Shank <perl@galumph.com>
Sat, 11 Oct 2008 03:40:51 +0000 (03:40 +0000)
is.

Changes
lib/Perl/Critic/Policy/Modules/RequireNoMatchVarsWithUseEnglish.pm
t/Modules/RequireNoMatchVarsWithUseEnglish.run

diff --git a/Changes b/Changes
index 020f2e8..68eebb5 100644 (file)
--- a/Changes
+++ b/Changes
@@ -17,7 +17,7 @@
     New Policies:
     * Miscellanea::ProhibitUnrestrictedNoCritic
     * Variables::ProhibitReusedNames
-    
+
 [1.093_01] Released on 2008-09-07
 
     New Developer Features:
index 33c7f68..4016d51 100644 (file)
@@ -166,7 +166,7 @@ documentation for details.
     use English;                              # not ok
     use English '-no_match_vars';             # ok
     use English qw< $ERRNO -no_match_vars>;   # ok
-
+    use English qw($OS_ERROR);                # not ok
 
 
 =head1 CONFIGURATION
index 1c48b27..e4f4c5e 100644 (file)
@@ -215,14 +215,6 @@ use English qw(-no_mactch_vars);
 
 #-----------------------------------------------------------------------------
 
-## name Pass with specific variable.  RT #39787
-## failures 0
-## cut
-
-use English qw($OS_ERROR);
-
-#-----------------------------------------------------------------------------
-
 ##############################################################################
 #      $URL$
 #     $Date$