Login
Committing the rest of my work on refactoring the handling of the
authorJeffrey Ryan Thalhammer <jeff@imaginative-software.com>
Mon, 10 Nov 2008 04:43:41 +0000 (04:43 +0000)
committerJeffrey Ryan Thalhammer <jeff@imaginative-software.com>
Mon, 10 Nov 2008 04:43:41 +0000 (04:43 +0000)
commitd5835ca8504dd9d34a1ec07debfb313557918068
tree8f3763aa733d7e7280e079e5402397c849516c4e
parent6873462071ed6a64c61bda872853708bd1aeff32
Committing the rest of my work on refactoring the handling of the
"## no critic" annotations.  This completes the integration with the
new Annotation class.

I also created a new ProhibitUselessNoCritic policy, which uses the
new capabilities of P::C::Document and P::C::Annotation to effectively
replace the --warn-about-useless-no-critc option.  Thanks Elliot for i
suggesting that we implement this as a Policy instead of an option.

Next, I want to change all the code and documentation to recharacterize
the "## no critic" thingies as "annotations".  Also need to write some
unit tests for P::C::Annotation and P::C::Document.  I've had success
using Test::Class at work lately, so I'm thinking of using it here.
19 files changed:
Changes
bin/perlcritic
examples/loadanalysisdb
inc/Perl/Critic/BuildUtilities.pm
lib/Perl/Critic.pm
lib/Perl/Critic/Annotation.pm
lib/Perl/Critic/Config.pm
lib/Perl/Critic/Document.pm
lib/Perl/Critic/OptionsProcessor.pm
lib/Perl/Critic/Policy/InputOutput/RequireBriefOpen.pm
lib/Perl/Critic/Policy/Miscellanea/ProhibitUnrestrictedNoCritic.pm
lib/Perl/Critic/Policy/Miscellanea/ProhibitUselessNoCritic.pm [new file with mode: 0644]
lib/Perl/Critic/Utils.pm
lib/Perl/Critic/Utils/McCabe.pm
t/03_pragmas.t
t/03_useless_pragmas.t [deleted file]
t/05_utils.t
t/07_perlcritic.t
t/Miscellanea/ProhibitUnrestrictedNoCritic.run